You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2018/01/05 00:46:54 UTC

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r159790956
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -156,29 +156,19 @@ public void cleanUp() {
       }
     
       @Override
    -  public int getQueryTimeout() throws AlreadyClosedSqlException
    +  public int getQueryTimeout() throws AlreadyClosedSqlException, SQLException
       {
         throwIfClosed();
    -    return 0;  // (No no timeout.)
    +    return super.getQueryTimeout();
       }
     
       @Override
    -  public void setQueryTimeout( int milliseconds )
    +  public void setQueryTimeout( int seconds )
           throws AlreadyClosedSqlException,
                  InvalidParameterSqlException,
    -             SQLFeatureNotSupportedException {
    +             SQLException {
    --- End diff --
    
    +1


---