You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2024/12/11 07:36:13 UTC

(lucene) 02/02: Add github on-commit tests on MacOS and Windows (#14054)

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/lucene.git

commit 559c4664eac88030617ca8f28a1cd76681190688
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Tue Dec 10 20:19:28 2024 +0100

    Add github on-commit tests on MacOS and Windows (#14054)
---
 .github/workflows/run-checks-all.yml | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/run-checks-all.yml b/.github/workflows/run-checks-all.yml
index 1bc0a0b564b..18dd308e9a7 100644
--- a/.github/workflows/run-checks-all.yml
+++ b/.github/workflows/run-checks-all.yml
@@ -34,11 +34,14 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
+      - name: Correct git autocrlf
+        run: git config --global core.autocrlf false
+
       - uses: actions/checkout@v4
       - uses: ./.github/actions/prepare-for-build
 
       - name: Run gradle check (without tests)
-        run: ./gradlew check -x test -Ptask.times=true --max-workers 2
+        run: ./gradlew check -x test "-Ptask.times=true" --max-workers 2
 
 
   # This runs all tests without any other validation checks.
@@ -49,14 +52,16 @@ jobs:
     strategy:
       matrix:
         # Operating systems to run on.
-        # windows-latest: fairly slow to build and results in odd errors (see LUCENE-10167)
-        # macos-latest: a tad slower than ubuntu and pretty much the same (?) so leaving out.
-        os: [ ubuntu-latest ]
+        os: [ ubuntu-latest, windows-latest, macos-latest ]
         java: [ '21' ]
 
     runs-on: ${{ matrix.os }}
 
     steps:
+      - name: Correct git autocrlf on Windows
+        if: startsWith(matrix.os, 'windows')
+        run: git config --global core.autocrlf false
+
       - uses: actions/checkout@v4
       - uses: ./.github/actions/prepare-for-build