[GitHub] [hive] asolimando commented on a diff in pull request #3820: HIVE-26692: Check for the expected thrift version before compiling

[GitBox <gi...@apache.org>]

asolimando commented on code in PR #3820:
URL: https://github.com/apache/hive/pull/3820#discussion_r1036382446


##########
pom.xml:
##########
@@ -1773,6 +1773,35 @@
       <id>thriftif</id>
       <build>
         <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>exec-maven-plugin</artifactId>
+            <version>1.2.1</version>

Review Comment:
   Thanks Ayush for noticing this, unfortunately the `standalone-metastore` pom does not inherit from the topmost one, so we can't share it, but I will introduce a variable with the same name and use the same version.
   
   I have tried locally, everything seems good (normal build and thrift generation, OK and KO paths).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org