[GitHub] mistercrunch commented on issue #3241: Improve the chart type of Visualize in sqllab

[gi...@git.apache.org]

mistercrunch commented on issue #3241: Improve the chart type of Visualize in sqllab
URL: https://github.com/apache/incubator-superset/pull/3241#issuecomment-320287037
 
 
   Many of the charts have requirements that won't be fulfilled when landing on the "explore view". I'd rather support only a subset of the charts in the "visualize flow" and make sure that we fill in the values needed for the controls for them to render properly as you land. 
   
   Your approach in building the dropdown is better though. Can you add a `.filter()` that specifies a subset of the vizTypes?
   
   Some of the controls like `metrics` will have pick a default value, but some required ones won't. Eventually we should make sure that all required field get a decent default so that the visualize flow always works.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services