You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/09 00:25:17 UTC

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5013

Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type()
......................................................................

Unbreak the build: Pull RowChangelistEncoder::get_type()

Misordered push of 3c68deacc05f6b5a9b82522baa38e046744b1815
caused the build to fail. This just pull that method in.

Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
---
M src/kudu/common/row_changelist.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5013/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type()
......................................................................


Unbreak the build: Pull RowChangelistEncoder::get_type()

Misordered push of 3c68deacc05f6b5a9b82522baa38e046744b1815
caused the build to fail. This just pulls that method in.

Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
Reviewed-on: http://gerrit.cloudera.org:8080/5013
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/common/row_changelist.h
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type()
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has uploaded a new patch set (#2).

Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type()
......................................................................

Unbreak the build: Pull RowChangelistEncoder::get_type()

Misordered push of 3c68deacc05f6b5a9b82522baa38e046744b1815
caused the build to fail. This just pulls that method in.

Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
---
M src/kudu/common/row_changelist.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5013/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If83f7d26ecc5632b6645b1aec927580f202f7d85
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins