[jira] [Comment Edited] (MINIFICPP-546) minifi.sh status should return 0 when process isn't running

["marco polo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525212#comment-16525212 ] 

marco polo edited comment on MINIFICPP-546 at 6/27/18 3:49 PM:
---------------------------------------------------------------

[~drodrigues] Why should it return 0? This case, I believe, is where we want to notify the caller that we have an unsuccessful exit, so a return code of zero would not indicate this. What purpose does changing this to successful serve? 


I'm guessing the original author wanted to serve this as being a notification mechanism when the status is intended to be running. [~aldrin], do you have any info on this?

 

 

Dustin is correct, it looks like it should be zero, but I'm worried this may break users and we should perhaps delay this for a separate release or at least make some notification. 


was (Author: phrocker):
[~drodrigues] Why should it return 0? This case, I believe, is where we want to notify the caller that we have an unsuccessful exit, so a return code of zero would not indicate this. What purpose does changing this to successful serve? Thanks

> minifi.sh status should return 0 when process isn't running
> -----------------------------------------------------------
>
>                 Key: MINIFICPP-546
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-546
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Dustin Rodrigues
>            Assignee: Dustin Rodrigues
>            Priority: Minor
>
> Currently, calling "minifi.sh status" when the process isn't running returns exit code 3. It should return 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)