You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/01 02:41:06 UTC

[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #3815: tools/mksyscall: Fix build break of syscall instrumentation wrapper

YuuichiNakamura opened a new pull request #3815:
URL: https://github.com/apache/incubator-nuttx/pull/3815


   ## Summary
   
   8334843 "Make noreturn proxies and stubs actually not return" doesn't support the syscall wrapper generation which is used by syscall instrumentation. So, the generated wrapper code occurs build break.
   This PR fixes the problem.
   
   ## Impact
   
   Only when  CONFIG_SCHED_INSTRUMENTATION_SYSCALL=y
   
   ## Testing
   
   Verified syscall instrumentation works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3815: tools/mksyscall: Fix build break of syscall instrumentation wrapper

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3815:
URL: https://github.com/apache/incubator-nuttx/pull/3815#issuecomment-851773584


   @YuuichiNakamura should we add a config to enable syscall instrumentation to catch the similar error in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #3815: tools/mksyscall: Fix build break of syscall instrumentation wrapper

Posted by GitBox <gi...@apache.org>.
YuuichiNakamura commented on pull request #3815:
URL: https://github.com/apache/incubator-nuttx/pull/3815#issuecomment-851795607


   @xiaoxiang781216 Thanks. Then how about adding the new configuration which enables the feature #3816 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3815: tools/mksyscall: Fix build break of syscall instrumentation wrapper

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3815:
URL: https://github.com/apache/incubator-nuttx/pull/3815


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3815: tools/mksyscall: Fix build break of syscall instrumentation wrapper

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3815:
URL: https://github.com/apache/incubator-nuttx/pull/3815#issuecomment-851798550


   > @xiaoxiang781216 Thanks. Then how about adding the new configuration which enables the feature #3816 ?
   
   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org