[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request #1279: TINKERPOP-2288 Replace closed connections directly

[GitBox <gi...@apache.org>]

FlorianHockmann commented on a change in pull request #1279:
URL: https://github.com/apache/tinkerpop/pull/1279#discussion_r429783491



##########
File path: docs/src/reference/gremlin-variants.asciidoc
##########
@@ -1090,10 +1090,13 @@ on the `ConnectionPoolSettings` instance that can be passed to the `GremlinClien
 |Key |Description |Default
 |PoolSize |The size of the connection pool. |4
 |MaxInProcessPerConnection |The maximum number of in-flight requests that can occur on a connection. |32
+|GetOpenConnectionRetries |The number of retries to get an open connection from the pool to submit a request. |4

Review comment:
       > Maybe we could use GetReconnectionAttempts() as a name?
   
   I also didn't like the name `GetOpenConnectionRetries` that much. `ReconnectionAttempts` sounds like a better name overall. I will probably omit the _Get_ prefix as it's a property and the _Get_ in `GetOpenConnectionRetries` meant the number of retries to _get_ a connection.
   
   > Instead of a number, it could return an IEnumerable<int>, that represents milliseconds to wait between each attempt.
   
   Do you think that users want to configure the individual wait times explicitly instead of just using the default exponential back-off? And wouldn't an `Action<int>` (or `Action<TimeSpan>`) be even more flexible and easier to configure in that case?
   If we let them configure an `Action` to compute the wait times, then it should probably be an additional option though as we would still need an option to configure the number of retries in general.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org