You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/28 22:19:37 UTC
[GitHub] linehrr commented on issue #23666: [SPARK-26718][SS] Fixed integer
overflow in SS kafka rateLimit calculation
linehrr commented on issue #23666: [SPARK-26718][SS] Fixed integer overflow in SS kafka rateLimit calculation
URL: https://github.com/apache/spark/pull/23666#issuecomment-458324882
> I'm wondering if you can minimize the overhead while achieving the same test coverage?
@dongjoon-hyun, I think I could. let me look into that. as long as I can prove test case will be able to trigger old bug then it should be a sufficient test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org