You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by noel-smith <gi...@git.apache.org> on 2015/09/02 10:46:40 UTC
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
GitHub user noel-smith opened a pull request:
https://github.com/apache/spark/pull/8571
[SPARK-10415][PySpark] Enhance Navigation Sidebar in PySpark API
These are CSS/JavaScript changes to add classes/functions + a few other tweaks to make navigation in the PySpark API a bit simpler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/noel-smith/spark pyspark-api-nav-enhance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8571
----
commit 06e3ddc40a18d5d8cecb1dccf84eac6bc2401b08
Author: noelsmith <ma...@noelsmith.com>
Date: 2015-08-31T21:44:34Z
Added class + function list to TOC
commit beaea590bf4f9d1852d885ef8f751088561d0aa2
Author: noelsmith <ma...@noelsmith.com>
Date: 2015-09-02T07:34:05Z
Simplified JavaScript + CSS tweaks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark][MLlib][Docs] Enhance Na...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-141723424
[Test build #1776 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1776/consoleFull) for PR 8571 at commit [`f0ae4fd`](https://github.com/apache/spark/commit/f0ae4fdc9802d71d0f6f8614ef524e8c80badd9d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark][MLlib][Docs] Enhance Na...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-141723995
[Test build #1776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1776/console) for PR 8571 at commit [`f0ae4fd`](https://github.com/apache/spark/commit/f0ae4fdc9802d71d0f6f8614ef524e8c80badd9d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-137114483
[Test build #1713 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1713/consoleFull) for PR 8571 at commit [`beaea59`](https://github.com/apache/spark/commit/beaea590bf4f9d1852d885ef8f751088561d0aa2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-137134995
[Test build #1713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1713/console) for PR 8571 at commit [`beaea59`](https://github.com/apache/spark/commit/beaea590bf4f9d1852d885ef8f751088561d0aa2).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class JavaTrainValidationSplitExample `
* `class KMeans @Since("1.5.0") (`
* `class LogisticRegressionModel @Since("1.3.0") (`
* `class SVMModel @Since("1.1.0") (`
* `class GaussianMixtureModel @Since("1.3.0") (`
* `class KMeansModel @Since("1.1.0") (@Since("1.0.0") val clusterCenters: Array[Vector])`
* `class PowerIterationClusteringModel @Since("1.3.0") (`
* `class StreamingKMeansModel @Since("1.2.0") (`
* `class StreamingKMeans @Since("1.2.0") (`
* `class BinaryClassificationMetrics @Since("1.3.0") (`
* `class MulticlassMetrics @Since("1.1.0") (predictionAndLabels: RDD[(Double, Double)]) `
* `class MultilabelMetrics @Since("1.2.0") (predictionAndLabels: RDD[(Array[Double], Array[Double])]) `
* `class RegressionMetrics @Since("1.2.0") (`
* `class ChiSqSelectorModel @Since("1.3.0") (`
* `class ChiSqSelector @Since("1.3.0") (`
* `class ElementwiseProduct @Since("1.4.0") (`
* `class IDF @Since("1.2.0") (@Since("1.2.0") val minDocFreq: Int) `
* `class Normalizer @Since("1.1.0") (p: Double) extends VectorTransformer `
* `class PCA @Since("1.4.0") (@Since("1.4.0") val k: Int) `
* `class StandardScaler @Since("1.1.0") (withMean: Boolean, withStd: Boolean) extends Logging `
* `class StandardScalerModel @Since("1.3.0") (`
* `class FPGrowthModel[Item: ClassTag] @Since("1.3.0") (`
* ` class FreqItemset[Item] @Since("1.3.0") (`
* ` class FreqSequence[Item] @Since("1.5.0") (`
* `class PrefixSpanModel[Item] @Since("1.5.0") (`
* `class DenseMatrix @Since("1.3.0") (`
* `class SparseMatrix @Since("1.3.0") (`
* `class DenseVector @Since("1.0.0") (`
* `class SparseVector @Since("1.0.0") (`
* `class BlockMatrix @Since("1.3.0") (`
* `class CoordinateMatrix @Since("1.0.0") (`
* `class IndexedRowMatrix @Since("1.0.0") (`
* `class RowMatrix @Since("1.0.0") (`
* `class PoissonGenerator @Since("1.1.0") (`
* `class ExponentialGenerator @Since("1.3.0") (`
* `class GammaGenerator @Since("1.3.0") (`
* `class LogNormalGenerator @Since("1.3.0") (`
* `case class Rating @Since("0.8.0") (`
* `class MatrixFactorizationModel @Since("0.8.0") (`
* `abstract class GeneralizedLinearModel @Since("1.0.0") (`
* `class IsotonicRegressionModel @Since("1.3.0") (`
* `case class LabeledPoint @Since("1.0.0") (`
* `class LassoModel @Since("1.1.0") (`
* `class LinearRegressionModel @Since("1.1.0") (`
* `class RidgeRegressionModel @Since("1.1.0") (`
* `class MultivariateGaussian @Since("1.3.0") (`
* `case class BoostingStrategy @Since("1.4.0") (`
* `class Strategy @Since("1.3.0") (`
* `class DecisionTreeModel @Since("1.0.0") (`
* `class Node @Since("1.2.0") (`
* `class Predict @Since("1.2.0") (`
* `class RandomForestModel @Since("1.2.0") (`
* `class GradientBoostedTreesModel @Since("1.2.0") (`
* `class DCT(JavaTransformer, HasInputCol, HasOutputCol):`
* `class SQLTransformer(JavaTransformer):`
* `class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):`
* `abstract class SetOperation(left: LogicalPlan, right: LogicalPlan) extends BinaryNode `
* `case class Union(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right) `
* `case class Intersect(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)`
* `case class Except(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)`
* `case class LimitNode(limit: Int, child: LocalNode) extends UnaryLocalNode `
* `case class UnionNode(children: Seq[LocalNode]) extends LocalNode `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139384526
[Test build #1738 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1738/consoleFull) for PR 8571 at commit [`0781164`](https://github.com/apache/spark/commit/0781164b3fddc3e95572930a9d0e1ee84edef268).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by noel-smith <gi...@git.apache.org>.
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139387988
Hmm that's odd - that's exactly the way I'm building too. Did your generated html pages include the links to the `pyspark.js` and `pyspark.css` files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139392681
[Test build #1738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1738/console) for PR 8571 at commit [`0781164`](https://github.com/apache/spark/commit/0781164b3fddc3e95572930a9d0e1ee84edef268).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by noel-smith <gi...@git.apache.org>.
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139411836
Nice - thanks for finding that!
It probably indicates I need to make the JS logic a bit more robust though. I'll take a look at the Sphinx history and find out how it's changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-136980261
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark][MLlib][Docs] Enhance Na...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8571#discussion_r39215185
--- Diff: python/docs/_templates/layout.html ---
@@ -0,0 +1,6 @@
+{% extends "!layout.html" %}
+{% set script_files = script_files + ["_static/pyspark.js"] %}
+{% set css_files = css_files + ['_static/pyspark.css'] %}
+{% block rootrellink %}
+ {{ super() }}
+{% endblock %}
--- End diff --
new line here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139384205
@noel-smith I tried this locally, after `$ make html` in python/docs, can't get the sidebar work, did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139410001
That link work well, I'm using Mac with Homebrew, should I update Sphinx ? Currently running v1.2.3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-137113879
Looks pretty simple to me. The change is visually appealing. It would be great to get a third opinion on that before proceeding
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by noel-smith <gi...@git.apache.org>.
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-141709019
Tweaked JavaScript to make it more robust to Sphinx changes. Set minimal version of Sphinx to `1.2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139410300
After update Sphinx to 1.3.1, it worked! We may need to update this: `needs_sphinx = '1.3'`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by noel-smith <gi...@git.apache.org>.
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139404962
@davies Could you let me know your browser/platform + whether the example [link](https://dl.dropboxusercontent.com/u/20821334/pyspark-api-nav-enhance/pyspark.mllib.html) works for you? I'll try and reproduce locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139398712
@noel-smith Yes, I saw them in the generated html. There is a sidebar on the left, but all the titles are empty (but having E flag).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark][MLlib][Docs] Enhance Na...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-144181403
Merging this into master, thanks for the great job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8571#discussion_r39215265
--- Diff: python/docs/_static/pyspark.css ---
@@ -0,0 +1,73 @@
+body {
--- End diff --
Add license header here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10415][PySpark] Enhance Navigation Side...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8571#issuecomment-139382104
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org