You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2018/12/10 08:58:01 UTC

[PR-2803]: Fix telnet can not find method with enum type

@LiZhenNet,

I left my review comments on PR2803 [1], pls. take a look when you notice
this email.

Thanks,
-Ian.

1. https://github.com/apache/incubator-dubbo/pull/2803

Re: [PR-2803]: Fix telnet can not find method with enum type

Posted by Ian Luo <ia...@gmail.com>.
Sure. I will move your change in. It is not a big deal. We can revisit it
later if performance is a concern.

-Ian.

On Mon, Dec 10, 2018 at 8:30 PM 李振 <li...@gmail.com> wrote:

> @Ian Luo
>
> 我感觉你建议的改法可能有些问题,我的方案只是性能不好,但是我认为telnet 用途主要是debug ,可以不太关注性能。
>
>  I feel that your proposed modification may have some problems. My solution
> is just poor performance, but I think telnet is mainly used for debugging,
> and can pay less attention to performance.
>
> Ian Luo <ia...@gmail.com> 于2018年12月10日周一 下午4:58写道:
>
> > @LiZhenNet,
> >
> > I left my review comments on PR2803 [1], pls. take a look when you notice
> > this email.
> >
> > Thanks,
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/pull/2803
> >
>

Re: [PR-2803]: Fix telnet can not find method with enum type

Posted by 李振 <li...@gmail.com>.
@Ian Luo

我感觉你建议的改法可能有些问题,我的方案只是性能不好,但是我认为telnet 用途主要是debug ,可以不太关注性能。

 I feel that your proposed modification may have some problems. My solution
is just poor performance, but I think telnet is mainly used for debugging,
and can pay less attention to performance.

Ian Luo <ia...@gmail.com> 于2018年12月10日周一 下午4:58写道:

> @LiZhenNet,
>
> I left my review comments on PR2803 [1], pls. take a look when you notice
> this email.
>
> Thanks,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/pull/2803
>