[GitHub] [pulsar] MarvinCai commented on a diff in pull request #17411: Check create topic permission on topic creation using pulsar proto clients

[GitBox <gi...@apache.org>]

MarvinCai commented on code in PR #17411:
URL: https://github.com/apache/pulsar/pull/17411#discussion_r965955934


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java:
##########
@@ -482,12 +482,12 @@ public CompletableFuture<Boolean> allowNamespaceOperationAsync(NamespaceName nam
                             case GET_TOPIC:
                             case GET_TOPICS:
                             case GET_BUNDLE:
+                            case CREATE_TOPIC:
                                 return allowConsumeOrProduceOpsAsync(namespaceName, role, authData);

Review Comment:
   seems we're only checking permission for `consume` or `produce` action here, I'm wondering what's the benefit of this pr while we don't have a action for `create_topic` itself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org