You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "heliang666s (via GitHub)" <gi...@apache.org> on 2025/09/13 17:30:52 UTC
[PR] fix：fix bugs detected by doubao [incubator-seata-go]
heliang666s opened a new pull request, #883:
URL: https://github.com/apache/incubator-seata-go/pull/883
fix bugs detected by doubao #879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix：fix bugs detected by doubao [incubator-seata-go]
Posted by "lxfeng1997 (via GitHub)" <gi...@apache.org>.
lxfeng1997 merged PR #883:
URL: https://github.com/apache/incubator-seata-go/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix：fix bugs detected by doubao [incubator-seata-go]
Posted by "maronghe (via GitHub)" <gi...@apache.org>.
maronghe commented on code in PR #883:
URL: https://github.com/apache/incubator-seata-go/pull/883#discussion_r2347058055
##########
pkg/datasource/sql/conn_at_test.go:
##########
@@ -238,3 +243,23 @@ func TestATConn_BeginTx(t *testing.T) {
assert.Equal(t, int32(1), atomic.LoadInt32(&comitCnt))
})
}
+
+type mockTxHook struct {
+ beforeCommit func(tx *Tx) error
+ beforeRollback func(tx *Tx)
+}
+
+// BeforeCommit
+func (mi *mockTxHook) BeforeCommit(tx *Tx) error {
+ if mi.beforeCommit != nil {
+ return mi.beforeCommit(tx)
+ }
+ return nil
+}
+
+// BeforeRollback
+func (mi *mockTxHook) BeforeRollback(tx *Tx) {
Review Comment:
need return error or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix：fix bugs detected by doubao [incubator-seata-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #883:
URL: https://github.com/apache/incubator-seata-go/pull/883#issuecomment-3288690534
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `13.75000%` with `69 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 38.17%. Comparing base ([`f25b22c`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/f25b22c8f03aa63317ae212a97345f071a24fa39?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`78a9ed1`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/78a9ed172d1c1c5c6f40ecead4986adac69b3fd5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [pkg/datasource/sql/exec/at/base\_executor.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fexec%2Fat%2Fbase_executor.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL2V4ZWMvYXQvYmFzZV9leGVjdXRvci5nbw==) | 7.69% | [48 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/tx.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Ftx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3R4Lmdv) | 28.57% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/discovery/etcd3.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdiscovery%2Fetcd3.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2Rpc2NvdmVyeS9ldGNkMy5nbw==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/driver.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fdriver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL2RyaXZlci5nbw==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/tx\_at.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Ftx_at.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3R4X2F0Lmdv) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/tx\_xa.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Ftx_xa.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3R4X3hhLmdv) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/conn\_xa.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fconn_xa.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL2Nvbm5feGEuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mysql\_insertonduplicate\_update\_undo\_log\_builder.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fundo%2Fbuilder%2Fmysql_insertonduplicate_update_undo_log_builder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3VuZG8vYnVpbGRlci9teXNxbF9pbnNlcnRvbmR1cGxpY2F0ZV91cGRhdGVfdW5kb19sb2dfYnVpbGRlci5nbw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/rm/tcc/fence/fence\_driver.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&filepath=pkg%2Frm%2Ftcc%2Ffence%2Ffence_driver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3JtL3RjYy9mZW5jZS9mZW5jZV9kcml2ZXIuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 38.33% 38.17% -0.16%
==========================================
Files 188 188
Lines 11364 11417 +53
==========================================
+ Hits 4356 4359 +3
- Misses 6581 6628 +47
- Partials 427 430 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-seata-go/pull/883?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org