You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/30 03:45:45 UTC
[GitHub] [calcite] Aaaaaaron opened a new pull request #1706: minor,
fix a typo.
Aaaaaaron opened a new pull request #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706
Is this a typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1706: minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
chunweilei commented on issue #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#issuecomment-569849062
> > Maybe we can merge it with another pr.
>
> which PR?
PR which is not trivial such as bug fix or a feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron commented on issue #1706: minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on issue #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#issuecomment-569654671
> Maybe we can merge it with another pr.
which PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1706:
minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#discussion_r361904558
##########
File path: core/src/main/java/org/apache/calcite/materialize/LatticeSuggester.java
##########
@@ -334,7 +334,7 @@ private Lattice findMatch(final Lattice lattice, MutableNode mutableNode) {
}
if (bestMatch != null) {
- // Fix up the best batch
+ // Fix up the best match
Review comment:
Yes, thanks for the fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron edited a comment on issue #1706: CALCITE-3770,
minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on issue #1706: CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you think it needs to be modified in history.md(IMHO, we shouldn't)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron commented on issue #1706: CALCITE-3770,
minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on issue #1706: CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] xy2953396112 commented on issue #1706: minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on issue #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#issuecomment-569646467
> Maybe we can merge it with another pr.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron edited a comment on issue #1706: CALCITE-3770,
minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on issue #1706: CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you think it needs to be modified in history.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron commented on a change in pull request #1706:
minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on a change in pull request #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#discussion_r361905943
##########
File path: core/src/main/java/org/apache/calcite/materialize/LatticeSuggester.java
##########
@@ -334,7 +334,7 @@ private Lattice findMatch(final Lattice lattice, MutableNode mutableNode) {
}
if (bestMatch != null) {
- // Fix up the best batch
+ // Fix up the best match
Review comment:
You are welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] julianhyde commented on issue #1706: CALCITE-3770,
minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
Posted by GitBox <gi...@apache.org>.
julianhyde commented on issue #1706: CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585365757
> And one thing I want to for sure, do you think it needs to be modified in history.md? IMHO, we shouldn't.
I agree. Don't change history. It is (basically) a log of commit messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] Aaaaaaron edited a comment on issue #1706: CALCITE-3770,
minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on issue #1706: CALCITE-3770, minor change "EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you think it needs to be modified in history.md? IMHO, we shouldn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1706: minor, fix a typo.
Posted by GitBox <gi...@apache.org>.
chunweilei commented on issue #1706: minor, fix a typo.
URL: https://github.com/apache/calcite/pull/1706#issuecomment-569629681
Maybe we can merge it with another pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services