You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/16 18:06:48 UTC

[GitHub] [incubator-mxnet] MoisesHer commented on a change in pull request #18082: Add gelu fuse ops

MoisesHer commented on a change in pull request #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#discussion_r409751099
 
 

 ##########
 File path: src/operator/fusion/fused_op-inl.h
 ##########
 @@ -543,6 +552,13 @@ __device__ inline DType relu(const DType val) {
   return val > 0 ? val : 0;
 }
 
+__constant__ const float SQRT_2 = 1.4142135623730950488016887242096;
 
 Review comment:
   Thank you, I just removed "__constant__" 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services