You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/10/27 23:21:37 UTC

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25228


Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................

[consensus] relax mem ordering on leader_transfer_in_progress_

Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/25228/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3189/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 00:05:03 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 15:10:39 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3189/


-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 27 Oct 2026 23:21:46 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................

[consensus] relax mem ordering on leader_transfer_in_progress_

Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Reviewed-on: http://gerrit.cloudera.org:8080/25228
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Marton Greber: Looks good to me, approved
  Gabriella Lotz: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Patch Set 1: Verified+1

unrelated failures of known flaky tests:
  * DEBUG: KUDU-3052
  * TSAN: KUDU-3596 ?


-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 02:50:53 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] relax mem ordering on leader transfer in progress

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/25228 )

Change subject: [consensus] relax mem ordering on leader_transfer_in_progress_
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/25228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id298e5b3a510a2e22c5eebd6d221623d1052e0c9
Gerrit-Change-Number: 25228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 09:25:31 +0000
Gerrit-HasComments: No