[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6037: Port math.rs to sqllogictest

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6037:
URL: https://github.com/apache/arrow-datafusion/pull/6037#discussion_r1170178093


##########
datafusion/core/tests/sqllogictests/test_files/math.slt:
##########
@@ -87,3 +87,24 @@ query RRRRRRRR
 SELECT round(125.2345, -3), round(125.2345, -2), round(125.2345, -1), round(125.2345), round(125.2345, 0), round(125.2345, 1), round(125.2345, 2), round(125.2345, 3)
 ----
 0 100 130 125 125 125.2 125.23 125.235
+
+# Create table for atan2 test
+statement ok

Review Comment:
   its good to drop table after the test completed, or as alternative you can prepare data in WITH clause.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org