You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jchen5 (via GitHub)" <gi...@apache.org> on 2024/04/02 20:25:23 UTC
[PR] [SPARK-47700][SQL] Fix formatting of error messages with treeNode [spark]
jchen5 opened a new pull request, #45825:
URL: https://github.com/apache/spark/pull/45825
### What changes were proposed in this pull request?
Fix formatting of error messages.
Example: In several error messages, we are concatenating the plan without any separation: `in this locationFilter (dept_id#652`. We should add a colon and space or newline in between:
```
[UNSUPPORTED_SUBQUERY_EXPRESSION_CATEGORY.ACCESSING_OUTER_QUERY_COLUMN_IS_NOT_ALLOWED] Unsupported subquery expression: Accessing outer query column is not allowed in this locationFilter (dept_id#652 = outer(dept_id#646))
+- SubqueryAlias dept
+- View (`DEPT`, [dept_id#652, dept_name#653, state#654])
+- Project [cast(dept_id#655 as int) AS dept_id#652, cast(dept_name#656 as string) AS dept_name#653, cast(state#657 as string) AS state#654]
+- Project [dept_id#655, dept_name#656, state#657]
+- SubqueryAlias DEPT
+- LocalRelation [dept_id#655, dept_name#656, state#657]
. SQLSTATE: 0A000
```
### Why are the changes needed?
Improve error messages readability.
### Does this PR introduce _any_ user-facing change?
Improve error messages readability.
### How was this patch tested?
Unit tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47700][SQL] Fix formatting of error messages with treeNode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45825: [SPARK-47700][SQL] Fix formatting of error messages with treeNode
URL: https://github.com/apache/spark/pull/45825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47700][SQL] Fix formatting of error messages with treeNode [spark]
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #45825:
URL: https://github.com/apache/spark/pull/45825#issuecomment-2035049158
Updated, CI is passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47700][SQL] Fix formatting of error messages with treeNode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45825:
URL: https://github.com/apache/spark/pull/45825#issuecomment-2035812124
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org