You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/29 17:22:33 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #7612:
[flask] Updating dotenv setup
john-bodley opened a new pull request #7612: [flask] Updating dotenv setup
URL: https://github.com/apache/incubator-superset/pull/7612
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The `python-dotenv` is an extra requirement for Flask and thus it seemed prudent to specify it there. Additionally since we now leverage this feature explicitly defining the `FLASK_ENV` environment, i.e., `FLASK_ENV=development flask run` is no longer required and thus I updated `CONTRIBUTING.md` to reflect this change. Finally given that `--reload` and `--debugger` are enabled by default per,
```
--reload / --no-reload Enable or disable the reloader. By default
the reloader is active if debug is enabled.
--debugger / --no-debugger Enable or disable the debugger. By default
the debugger is active if debug is enabled.
```
there's no need to explicitly specify them.
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org