You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@giraph.apache.org by ac...@apache.org on 2013/05/07 00:06:36 UTC
[3/4] git commit: updated refs/heads/origin/trunk to 21467cf
GIRAPH-657: Remove unused reuseIncomingEdgeObjects option.
Project: http://git-wip-us.apache.org/repos/asf/giraph/repo
Commit: http://git-wip-us.apache.org/repos/asf/giraph/commit/81425f99
Tree: http://git-wip-us.apache.org/repos/asf/giraph/tree/81425f99
Diff: http://git-wip-us.apache.org/repos/asf/giraph/diff/81425f99
Branch: refs/heads/origin/trunk
Commit: 81425f99c4fe4a59846f15e7edb13ff1993b2a7b
Parents: 61ef4d2
Author: Alessandro Presta <al...@fb.com>
Authored: Mon May 6 12:06:56 2013 -0700
Committer: Avery Ching <ac...@fb.com>
Committed: Mon May 6 15:04:45 2013 -0700
----------------------------------------------------------------------
CHANGELOG | 2 ++
.../apache/giraph/conf/GiraphConfiguration.java | 9 ---------
.../org/apache/giraph/conf/GiraphConstants.java | 9 ---------
3 files changed, 2 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/CHANGELOG
----------------------------------------------------------------------
diff --git a/CHANGELOG b/CHANGELOG
index 6439581..8a2b9eb 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,6 +1,8 @@
Giraph Change Log
Release 1.0.1 - unreleased
+ GIRAPH-657: Remove unused reuseIncomingEdgeObjects option (apresta)
+
GIRAPH-592: YourKit profiler (nitay)
GIRAPH-618: Website Documentation: Aggregators (and sharded aggregators)
http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
----------------------------------------------------------------------
diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
index 48f3d4b..8d74626 100644
--- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
+++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
@@ -901,15 +901,6 @@ public class GiraphConfiguration extends Configuration
}
/**
- * Check if we can reuse incoming edge objects.
- *
- * @return True iff we can reuse incoming edge objects.
- */
- public boolean reuseIncomingEdgeObjects() {
- return GiraphConstants.REUSE_INCOMING_EDGE_OBJECTS.get(this);
- }
-
- /**
* Get the local hostname on the given interface.
*
* @return The local hostname
http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
----------------------------------------------------------------------
diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
index 0067c25..54a40b7 100644
--- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
+++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
@@ -421,15 +421,6 @@ public interface GiraphConstants {
new IntConfOption("giraph.maxMutationsPerRequest", 100);
/**
- * Whether we should reuse the same Edge object when adding edges from
- * requests.
- * This works with edge storage implementations that don't keep references
- * to the input Edge objects (e.g., ByteArrayVertex).
- */
- BooleanConfOption REUSE_INCOMING_EDGE_OBJECTS =
- new BooleanConfOption("giraph.reuseIncomingEdgeObjects", false);
-
- /**
* Use message size encoding (typically better for complex objects,
* not meant for primitive wrapped messages)
*/
Re: [3/4] git commit: updated refs/heads/origin/trunk to 21467cf
Posted by Avery Ching <ac...@apache.org>.
I screwed this up. Yeah, sorry. Deleted it.
Avery
On 5/7/13 3:37 PM, Nitay Joffe wrote:
> Avery,
>
> Did you really mean to push these to heads/origin/trunk (not heads/trunk)?
> If you look at the branches we now have origin/trunk and origin/origin/trunk because of this.
>
> - Nitay
>
> On May 6, 2013, at 6:06 PM, aching@apache.org wrote:
>
>> GIRAPH-657: Remove unused reuseIncomingEdgeObjects option.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/giraph/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/giraph/commit/81425f99
>> Tree: http://git-wip-us.apache.org/repos/asf/giraph/tree/81425f99
>> Diff: http://git-wip-us.apache.org/repos/asf/giraph/diff/81425f99
>>
>> Branch: refs/heads/origin/trunk
>> Commit: 81425f99c4fe4a59846f15e7edb13ff1993b2a7b
>> Parents: 61ef4d2
>> Author: Alessandro Presta <al...@fb.com>
>> Authored: Mon May 6 12:06:56 2013 -0700
>> Committer: Avery Ching <ac...@fb.com>
>> Committed: Mon May 6 15:04:45 2013 -0700
>>
>> ----------------------------------------------------------------------
>> CHANGELOG | 2 ++
>> .../apache/giraph/conf/GiraphConfiguration.java | 9 ---------
>> .../org/apache/giraph/conf/GiraphConstants.java | 9 ---------
>> 3 files changed, 2 insertions(+), 18 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/CHANGELOG
>> ----------------------------------------------------------------------
>> diff --git a/CHANGELOG b/CHANGELOG
>> index 6439581..8a2b9eb 100644
>> --- a/CHANGELOG
>> +++ b/CHANGELOG
>> @@ -1,6 +1,8 @@
>> Giraph Change Log
>>
>> Release 1.0.1 - unreleased
>> + GIRAPH-657: Remove unused reuseIncomingEdgeObjects option (apresta)
>> +
>> GIRAPH-592: YourKit profiler (nitay)
>>
>> GIRAPH-618: Website Documentation: Aggregators (and sharded aggregators)
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> ----------------------------------------------------------------------
>> diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> index 48f3d4b..8d74626 100644
>> --- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> +++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> @@ -901,15 +901,6 @@ public class GiraphConfiguration extends Configuration
>> }
>>
>> /**
>> - * Check if we can reuse incoming edge objects.
>> - *
>> - * @return True iff we can reuse incoming edge objects.
>> - */
>> - public boolean reuseIncomingEdgeObjects() {
>> - return GiraphConstants.REUSE_INCOMING_EDGE_OBJECTS.get(this);
>> - }
>> -
>> - /**
>> * Get the local hostname on the given interface.
>> *
>> * @return The local hostname
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> ----------------------------------------------------------------------
>> diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> index 0067c25..54a40b7 100644
>> --- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> +++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> @@ -421,15 +421,6 @@ public interface GiraphConstants {
>> new IntConfOption("giraph.maxMutationsPerRequest", 100);
>>
>> /**
>> - * Whether we should reuse the same Edge object when adding edges from
>> - * requests.
>> - * This works with edge storage implementations that don't keep references
>> - * to the input Edge objects (e.g., ByteArrayVertex).
>> - */
>> - BooleanConfOption REUSE_INCOMING_EDGE_OBJECTS =
>> - new BooleanConfOption("giraph.reuseIncomingEdgeObjects", false);
>> -
>> - /**
>> * Use message size encoding (typically better for complex objects,
>> * not meant for primitive wrapped messages)
>> */
>>
Re: [3/4] git commit: updated refs/heads/origin/trunk to 21467cf
Posted by Avery Ching <ac...@apache.org>.
I screwed this up. Yeah, sorry. Deleted it.
Avery
On 5/7/13 3:37 PM, Nitay Joffe wrote:
> Avery,
>
> Did you really mean to push these to heads/origin/trunk (not heads/trunk)?
> If you look at the branches we now have origin/trunk and origin/origin/trunk because of this.
>
> - Nitay
>
> On May 6, 2013, at 6:06 PM, aching@apache.org wrote:
>
>> GIRAPH-657: Remove unused reuseIncomingEdgeObjects option.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/giraph/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/giraph/commit/81425f99
>> Tree: http://git-wip-us.apache.org/repos/asf/giraph/tree/81425f99
>> Diff: http://git-wip-us.apache.org/repos/asf/giraph/diff/81425f99
>>
>> Branch: refs/heads/origin/trunk
>> Commit: 81425f99c4fe4a59846f15e7edb13ff1993b2a7b
>> Parents: 61ef4d2
>> Author: Alessandro Presta <al...@fb.com>
>> Authored: Mon May 6 12:06:56 2013 -0700
>> Committer: Avery Ching <ac...@fb.com>
>> Committed: Mon May 6 15:04:45 2013 -0700
>>
>> ----------------------------------------------------------------------
>> CHANGELOG | 2 ++
>> .../apache/giraph/conf/GiraphConfiguration.java | 9 ---------
>> .../org/apache/giraph/conf/GiraphConstants.java | 9 ---------
>> 3 files changed, 2 insertions(+), 18 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/CHANGELOG
>> ----------------------------------------------------------------------
>> diff --git a/CHANGELOG b/CHANGELOG
>> index 6439581..8a2b9eb 100644
>> --- a/CHANGELOG
>> +++ b/CHANGELOG
>> @@ -1,6 +1,8 @@
>> Giraph Change Log
>>
>> Release 1.0.1 - unreleased
>> + GIRAPH-657: Remove unused reuseIncomingEdgeObjects option (apresta)
>> +
>> GIRAPH-592: YourKit profiler (nitay)
>>
>> GIRAPH-618: Website Documentation: Aggregators (and sharded aggregators)
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> ----------------------------------------------------------------------
>> diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> index 48f3d4b..8d74626 100644
>> --- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> +++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
>> @@ -901,15 +901,6 @@ public class GiraphConfiguration extends Configuration
>> }
>>
>> /**
>> - * Check if we can reuse incoming edge objects.
>> - *
>> - * @return True iff we can reuse incoming edge objects.
>> - */
>> - public boolean reuseIncomingEdgeObjects() {
>> - return GiraphConstants.REUSE_INCOMING_EDGE_OBJECTS.get(this);
>> - }
>> -
>> - /**
>> * Get the local hostname on the given interface.
>> *
>> * @return The local hostname
>>
>> http://git-wip-us.apache.org/repos/asf/giraph/blob/81425f99/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> ----------------------------------------------------------------------
>> diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> index 0067c25..54a40b7 100644
>> --- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> +++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
>> @@ -421,15 +421,6 @@ public interface GiraphConstants {
>> new IntConfOption("giraph.maxMutationsPerRequest", 100);
>>
>> /**
>> - * Whether we should reuse the same Edge object when adding edges from
>> - * requests.
>> - * This works with edge storage implementations that don't keep references
>> - * to the input Edge objects (e.g., ByteArrayVertex).
>> - */
>> - BooleanConfOption REUSE_INCOMING_EDGE_OBJECTS =
>> - new BooleanConfOption("giraph.reuseIncomingEdgeObjects", false);
>> -
>> - /**
>> * Use message size encoding (typically better for complex objects,
>> * not meant for primitive wrapped messages)
>> */
>>