[jira] Resolved: (TRANSACTION-5) [transaction] GenericLockManager constructor ignores LoggerFacade argument

["Oliver Zeigermann (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/TRANSACTION-5?page=all ]
     
Oliver Zeigermann resolved TRANSACTION-5:
-----------------------------------------

    Resolution: Invalid

This is intended behavior. It is used to have a specific logger for the lock
manager.

> [transaction] GenericLockManager constructor ignores LoggerFacade argument
> --------------------------------------------------------------------------
>
>          Key: TRANSACTION-5
>          URL: http://issues.apache.org/jira/browse/TRANSACTION-5
>      Project: Commons Transaction
>         Type: Bug

>     Versions: 1.1.0
>  Environment: Operating System: All
> Platform: All
>     Reporter: Ky Vong

>
> In the following constructor for GenericLockManager, the LoggerFacade
> argument is ignored and a new LoggerFacade is always created.  Thus, the
> LoggerFacade that I'm passing in is never used.  This affects the
> subclasses of GenericLockManager as well since they all call this
> constructor.  Someone probably just did this temporarily for some debugging and
> forgot to set this.logger back to the LoggerFacade argument.
> Can this be fixed for 1.1?
> Thanks,
> Ky Vong
>     public GenericLockManager(int maxLockLevel, LoggerFacade logger, long
> timeoutMSecs,
>             long checkThreshholdMSecs) throws IllegalArgumentException {
>         if (maxLockLevel < 1)
>             throw new IllegalArgumentException("The maximum lock level must be
> at least 1 ("
>                     + maxLockLevel + " was specified)");
>         this.maxLockLevel = maxLockLevel;
>         this.logger = logger.createLogger("Locking");
>         this.globalTimeoutMSecs = timeoutMSecs;
>         this.checkThreshhold = checkThreshholdMSecs;
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org