You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/10/02 00:51:57 UTC
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
......................................................................
[NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
4 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/84/13484/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
index 5a3cde6..f7ed5e4 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
@@ -59,7 +59,7 @@
public abstract class AbstractNCUdfServlet extends AbstractServlet {
INcApplicationContext appCtx;
- INCServiceContext srvCtx;
+ protected INCServiceContext srvCtx;
protected final IApplicationContext plainAppCtx;
private final HttpScheme httpServerProtocol;
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
index 9efb6f8..029e5b6 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
@@ -131,7 +131,7 @@
return Collections.emptyMap();
}
- private void doCreate(DataverseName dataverseName, String libraryName, ExternalFunctionLanguage language,
+ protected void doCreate(DataverseName dataverseName, String libraryName, ExternalFunctionLanguage language,
String hash, URI downloadURI, boolean replaceIfExists, String sysAuthHeader,
IRequestReference requestReference, IServletRequest request) throws Exception {
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
@@ -142,7 +142,7 @@
sendMessage(req, responseFuture);
}
- private void doDrop(DataverseName dataverseName, String libraryName, boolean replaceIfExists,
+ protected void doDrop(DataverseName dataverseName, String libraryName, boolean replaceIfExists,
IRequestReference requestReference, IServletRequest request) throws Exception {
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
MessageFuture responseFuture = ncMb.registerMessageFuture();
@@ -152,7 +152,7 @@
sendMessage(req, responseFuture);
}
- private void sendMessage(ICcAddressedMessage requestMessage, MessageFuture responseFuture) throws Exception {
+ protected void sendMessage(ICcAddressedMessage requestMessage, MessageFuture responseFuture) throws Exception {
// Running on NC -> send 'execute' message to CC
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
InternalRequestResponse responseMsg;
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
index f23b6e4..8010fac 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
@@ -27,16 +27,16 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.lang.common.statement.CreateLibraryStatement;
-public final class CreateLibraryRequestMessage extends AbstractInternalRequestMessage {
+public class CreateLibraryRequestMessage extends AbstractInternalRequestMessage {
- final DataverseName dataverseName;
- final String libraryName;
- final ExternalFunctionLanguage lang;
- final String hash;
- final URI location;
- final boolean replaceIfExists;
- final String authToken;
private static final long serialVersionUID = 1L;
+ protected final DataverseName dataverseName;
+ protected final String libraryName;
+ protected final ExternalFunctionLanguage lang;
+ protected final String hash;
+ protected final URI location;
+ protected final boolean replaceIfExists;
+ protected final String authToken;
public CreateLibraryRequestMessage(String nodeRequestId, long requestMessageId, DataverseName dataverseName,
String libraryName, ExternalFunctionLanguage lang, String hash, URI location, boolean replaceIfExists,
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
index e7e8931..d5148e2 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
@@ -25,12 +25,12 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.lang.common.statement.LibraryDropStatement;
-public final class DropLibraryRequestMessage extends AbstractInternalRequestMessage {
+public class DropLibraryRequestMessage extends AbstractInternalRequestMessage {
- final DataverseName dataverseName;
- final String libraryName;
- final boolean ifExists;
private static final long serialVersionUID = 1L;
+ protected final DataverseName dataverseName;
+ protected final String libraryName;
+ protected final boolean ifExists;
public DropLibraryRequestMessage(String nodeRequestId, long requestMessageId, DataverseName dataverseName,
String libraryName, boolean ifExists, IRequestReference requestReference,
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Return outcome on create library / function
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Till Westmann <ti...@apache.org>:
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Return outcome on create library / function
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Sun, 03 Oct 2021 16:53:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
......................................................................
[NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
4 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/84/13484/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
index 5a3cde6..f7ed5e4 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java
@@ -59,7 +59,7 @@
public abstract class AbstractNCUdfServlet extends AbstractServlet {
INcApplicationContext appCtx;
- INCServiceContext srvCtx;
+ protected INCServiceContext srvCtx;
protected final IApplicationContext plainAppCtx;
private final HttpScheme httpServerProtocol;
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
index 9efb6f8..029e5b6 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java
@@ -131,7 +131,7 @@
return Collections.emptyMap();
}
- private void doCreate(DataverseName dataverseName, String libraryName, ExternalFunctionLanguage language,
+ protected void doCreate(DataverseName dataverseName, String libraryName, ExternalFunctionLanguage language,
String hash, URI downloadURI, boolean replaceIfExists, String sysAuthHeader,
IRequestReference requestReference, IServletRequest request) throws Exception {
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
@@ -142,7 +142,7 @@
sendMessage(req, responseFuture);
}
- private void doDrop(DataverseName dataverseName, String libraryName, boolean replaceIfExists,
+ protected void doDrop(DataverseName dataverseName, String libraryName, boolean replaceIfExists,
IRequestReference requestReference, IServletRequest request) throws Exception {
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
MessageFuture responseFuture = ncMb.registerMessageFuture();
@@ -152,7 +152,7 @@
sendMessage(req, responseFuture);
}
- private void sendMessage(ICcAddressedMessage requestMessage, MessageFuture responseFuture) throws Exception {
+ protected void sendMessage(ICcAddressedMessage requestMessage, MessageFuture responseFuture) throws Exception {
// Running on NC -> send 'execute' message to CC
INCMessageBroker ncMb = (INCMessageBroker) srvCtx.getMessageBroker();
InternalRequestResponse responseMsg;
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
index f23b6e4..8010fac 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/CreateLibraryRequestMessage.java
@@ -27,16 +27,16 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.lang.common.statement.CreateLibraryStatement;
-public final class CreateLibraryRequestMessage extends AbstractInternalRequestMessage {
+public class CreateLibraryRequestMessage extends AbstractInternalRequestMessage {
- final DataverseName dataverseName;
- final String libraryName;
- final ExternalFunctionLanguage lang;
- final String hash;
- final URI location;
- final boolean replaceIfExists;
- final String authToken;
private static final long serialVersionUID = 1L;
+ protected final DataverseName dataverseName;
+ protected final String libraryName;
+ protected final ExternalFunctionLanguage lang;
+ protected final String hash;
+ protected final URI location;
+ protected final boolean replaceIfExists;
+ protected final String authToken;
public CreateLibraryRequestMessage(String nodeRequestId, long requestMessageId, DataverseName dataverseName,
String libraryName, ExternalFunctionLanguage lang, String hash, URI location, boolean replaceIfExists,
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
index e7e8931..d5148e2 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/DropLibraryRequestMessage.java
@@ -25,12 +25,12 @@
import org.apache.asterix.lang.common.base.Statement;
import org.apache.asterix.lang.common.statement.LibraryDropStatement;
-public final class DropLibraryRequestMessage extends AbstractInternalRequestMessage {
+public class DropLibraryRequestMessage extends AbstractInternalRequestMessage {
- final DataverseName dataverseName;
- final String libraryName;
- final boolean ifExists;
private static final long serialVersionUID = 1L;
+ protected final DataverseName dataverseName;
+ protected final String libraryName;
+ protected final boolean ifExists;
public DropLibraryRequestMessage(String nodeRequestId, long requestMessageId, DataverseName dataverseName,
String libraryName, boolean ifExists, IRequestReference requestReference,
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Return outcome on create library / function
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Return outcome on create library / function
......................................................................
Patch Set 2: Code-Review+1
This change is ready for review.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Sat, 02 Oct 2021 19:40:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Return outcome on create library / function
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Return outcome on create library / function
......................................................................
Patch Set 2: Contrib-2
Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/K2cTTgaKTZANEbww9 : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Comment-Date: Sat, 02 Oct 2021 19:50:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484 )
Change subject: [NO ISSUE][*DB][UDF] Allow [Create|Drop]LibraryRequestMessage extension
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12575/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13484
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iad2485982f24ffe4de2fb34454df03aa891b25bc
Gerrit-Change-Number: 13484
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Sat, 02 Oct 2021 01:57:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment