You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2019/09/03 22:11:26 UTC

[incubator-iceberg] branch master updated: Python: Fix test failing CI builds (#445)

This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 03399cb  Python: Fix test failing CI builds (#445)
03399cb is described below

commit 03399cbe9a2255db317145d8280123ffdb8e227f
Author: TGooch44 <te...@gmail.com>
AuthorDate: Tue Sep 3 15:11:21 2019 -0700

    Python: Fix test failing CI builds (#445)
---
 python/iceberg/api/expressions/residual_evaluator.py | 2 --
 python/iceberg/api/types/types.py                    | 8 ++++----
 python/iceberg/core/avro/avro_schema_util.py         | 1 +
 python/iceberg/core/filesystem/s3_filesystem.py      | 1 -
 python/iceberg/core/table_properties.py              | 1 -
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/python/iceberg/api/expressions/residual_evaluator.py b/python/iceberg/api/expressions/residual_evaluator.py
index d8d506f..285abae 100644
--- a/python/iceberg/api/expressions/residual_evaluator.py
+++ b/python/iceberg/api/expressions/residual_evaluator.py
@@ -15,8 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-import threading
-
 from .expressions import Expressions, ExpressionVisitors
 from .predicate import BoundPredicate, Predicate, UnboundPredicate
 
diff --git a/python/iceberg/api/types/types.py b/python/iceberg/api/types/types.py
index 941c9bc..3734630 100644
--- a/python/iceberg/api/types/types.py
+++ b/python/iceberg/api/types/types.py
@@ -371,8 +371,8 @@ class BinaryType(PrimitiveType):
 class DecimalType(PrimitiveType):
 
     @staticmethod
-    def of(precison, scale):
-        return DecimalType(precison, scale)
+    def of(precision, scale):
+        return DecimalType(precision, scale)
 
     def __init__(self, precision, scale):
         if int(precision) > 38:
@@ -385,7 +385,7 @@ class DecimalType(PrimitiveType):
         return TypeID.DECIMAL
 
     def __repr__(self):
-        return "decimal(%s,%s)" % (self.precision, self.scale)
+        return "decimal(%s, %s)" % (self.precision, self.scale)
 
     def __str__(self):
         return self.__repr__()
@@ -396,7 +396,7 @@ class DecimalType(PrimitiveType):
         elif other is None or not isinstance(other, DecimalType):
             return False
 
-        return self.precision == other.precison and self.scale == other.scale
+        return self.precision == other.precision and self.scale == other.scale
 
     def __ne__(self, other):
         return not self.__eq__(other)
diff --git a/python/iceberg/core/avro/avro_schema_util.py b/python/iceberg/core/avro/avro_schema_util.py
index 5d47890..f513a9c 100644
--- a/python/iceberg/core/avro/avro_schema_util.py
+++ b/python/iceberg/core/avro/avro_schema_util.py
@@ -15,6 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
+
 class AvroSchemaUtil(object):
     FIELD_ID_PROP = "field-id"
     KEY_ID_PROP = "key-id"
diff --git a/python/iceberg/core/filesystem/s3_filesystem.py b/python/iceberg/core/filesystem/s3_filesystem.py
index 9423ee0..6843df6 100644
--- a/python/iceberg/core/filesystem/s3_filesystem.py
+++ b/python/iceberg/core/filesystem/s3_filesystem.py
@@ -40,7 +40,6 @@ ROLE_ARN = "default"
 AUTOREFRESH_SESSION = None
 
 
-
 @retry(wait_incrementing_start=100, wait_exponential_multiplier=4,
        wait_exponential_max=5000, stop_max_delay=600000, stop_max_attempt_number=7)
 def get_s3(obj="resource"):
diff --git a/python/iceberg/core/table_properties.py b/python/iceberg/core/table_properties.py
index 0511142..a50546c 100644
--- a/python/iceberg/core/table_properties.py
+++ b/python/iceberg/core/table_properties.py
@@ -16,7 +16,6 @@
 # under the License.
 
 
-
 class TableProperties(object):
     COMMIT_NUM_RETRIES = "commit.retry.num-retries"
     COMMIT_NUM_RETRIES_DEFAULT = 4