You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/26 21:22:19 UTC

[GitHub] [camel-quarkus] Xxyumi-hub opened a new pull request #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Xxyumi-hub opened a new pull request #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990
 
 
   CAMEL-13704 - https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-13704?filter=allopenissues
   I have created a PR template file for this repo, this will set a format for future PRs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] Xxyumi-hub edited a comment on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.
Xxyumi-hub edited a comment on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990#issuecomment-604696219
 
 
   Should I just have the below notes in the PR template?  (I have removed comments relating to JIRA)
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] Xxyumi-hub commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.
Xxyumi-hub commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990#issuecomment-605380425
 
 
   Thank you for the feedback! I have edited the file with the proposed changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990#issuecomment-604894462
 
 
   I'd propose something like this:
   
   [ ] An [issue](https://github.com/apache/camel-quarkus/issues) should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by `#`.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like `Fix #<issueNumber>` or `Fixes #<issueNumber>` will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run `mvn process-resources -Pformat` (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga merged pull request #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] Xxyumi-hub commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include

Posted by GitBox <gi...@apache.org>.
Xxyumi-hub commented on issue #990: [CAMEL-13704] - Added PR template file with instructions on what to include
URL: https://github.com/apache/camel-quarkus/pull/990#issuecomment-604696219
 
 
   Should I just have the below notes in the PR template?  (I have removed comments relating to JIRA)
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services