You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/10/19 09:11:04 UTC
[GitHub] [bookkeeper] RaulGracia opened a new pull request #2838: Issue 2837: Remove unnecessary log bindings from Bookkeeper packages
RaulGracia opened a new pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838
### Motivation
Remove log bindings from `bookkeeper-common` and `bookkeeper-server` packages.
### Changes
(WORK IN PROGRESS)
- Removed log4j bindings from `bookkeeper-common` and `bookkeeper-server` main code:
- In both packages, these bindings are only used in `test` scope, as there are tests that directly rely on log4j APIs for their test logic.
- To allow `bookkeeper-server` to work only with slf4j, we needed to remove direct use of log4j API in `FileSystemUpgrade` class.
Master Issue: #2837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951175326
Looks very good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-948932899
@RaulGracia Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952756617
@zymap have you reviewed this PR ? can we merge to master in your opinion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951176472
Looks good to me. Approved.
Thanks
-Prashant.
On Mon, Oct 25, 2021 at 10:52 AM Raúl Gracia ***@***.***>
wrote:
> @eolivelli <https://github.com/eolivelli> @pkumar-singh
> <https://github.com/pkumar-singh> @zymap <https://github.com/zymap> I
> think that this PR now addresses the original comment
> <https://github.com/apache/bookkeeper/pull/2816#discussion_r729987757>
> that suggested that we should not be bringing log implementation bindings
> in neither bookkeeper-server and bookkeeper-common. Note that for
> bookkeeper-common this was true, but I think that was not the case for
> bookkeeper-server (as visible, FileSystemUpgrade class was using log4j
> APIs within bookkeeper-server main code). I have set this PR ready to
> review, so it would be great to get your feedback about it.
>
> Also, this PR has been tagged as version 4.14.3, but I think that this is
> not correct; This PR is related to PR #2816
> <https://github.com/apache/bookkeeper/pull/2816> that targets 4.15
> (current master).
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/bookkeeper/pull/2838#issuecomment-951162401>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APQ5IN4KNKOFRE633ZADN53UIWKMTANCNFSM5GIT2YDQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#discussion_r735991509
##########
File path: bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt
##########
@@ -232,8 +232,6 @@ Apache Software License, Version 2.
- lib/io.netty-netty-transport-native-unix-common-4.1.68.Final.jar [11]
- lib/org.apache.logging.log4j-log4j-1.2-api-2.14.1.jar [16]
- lib/org.apache.logging.log4j-log4j-api-2.14.1.jar [16]
-- lib/org.apache.logging.log4j-log4j-core-2.14.1.jar [16]
Review comment:
For bkctl, which logging framework are we using?
I believe that we should bundle the implementation package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952098518
@eolivelli you are right and I posted the same here: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951162401
This is a change related to another PR that is only in `master`, so it should not go to branch `4.14`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952629881
@zymap, @eolivelli is right, PR #2816 focuses on `master` only, as well as this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952869393
committed to master branch, thank you @RaulGracia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-950434339
Tests failure:
```
org.apache.bookkeeper.tests.integration.stream.BkCtlTest
Test simpleTest FAILED (2.6s)
java.lang.AssertionError
at org.apache.bookkeeper.tests.integration.stream.BkCtlTest.simpleTest(BkCtlTest.java:84)
Test putGetKey PASSED (5.9s)
Test createTable PASSED (2.2s)
Test createNamespace PASSED (2.3s)
Test listBookies FAILED
java.lang.AssertionError
at org.apache.bookkeeper.tests.integration.stream.BkCtlTest.listBookies(BkCtlTest.java:51)
Test incGetKey PASSED (6.2s)
Test showLastMark FAILED
java.lang.AssertionError
at org.apache.bookkeeper.tests.integration.stream.BkCtlTest.showLastMark(BkCtlTest.java:66)
```
@RaulGracia Could you please take a look at the failure tests? I rerun the tests and it still failed 😕
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951162401
@eolivelli @pkumar-singh @zymap I think that this PR now addresses the [original comment](https://github.com/apache/bookkeeper/pull/2816#discussion_r729987757) that suggested that we should not be bringing log implementation bindings in neither `bookkeeper-server` and `bookkeeper-common`. Note that for `bookkeeper-common` this was true, but I think that was not the case for `bookkeeper-server` (as visible, `FileSystemUpgrade` class was using log4j APIs within `bookkeeper-server` main code). I have set this PR ready to review, so it would be great to get your feedback about it.
Also, this PR has been tagged as version 4.14.3, but I think that this is not correct; This PR is related to PR #2816 that targets 4.15 (current `master`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952599256
@zymap yes, I would remove this work (#2816) from branch-4.14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952434128
So should I remove the #2816 from 4.14.x as well? Because this PR looks like an improvement of PR #2816. @eolivelli @RaulGracia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-948636206
Thanks @zymap, I sent out this PR out for getting feedback related to this comment: https://github.com/apache/bookkeeper/pull/2816/files#r729987757. It is in draft mode to prevent it from getting merged before we agree that it addresses the original comment. Now I see that there is a conflict from a recent merge, I will resolve it.
cc/ @pkumar-singh @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-950622773
Thanks @zymap, I think that the problem may be as follows:
- The comments in the original PR #2816 suggested to remove Log4j bindings from `bookkeeper-common` and `bookkeeper-server` (at least from the main code).
- I have been able to do that for `bookkeeper-common`.
- I have done the same for `bookkeeper-server`. However, it looks like this module was importing (even before PR #2816) some of these binding dependencies, given that when I remove them, integration tests fail. The failures are related to some tests that relay on the log output to validate `bkctl` commands.
I will work on finding the best way to make `bkctl` to have the necessary log4j dependencies, while removing them from `bookkeeper-server`, as this was the original comment. My only concern is whether or not there could be more modules relying on the log4j bindings in the same way as `bkctl` tests do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-952093877
I am not sure that this change fits 4.14.x, because we are changing the dependencies, it is kind of breaking change.
WDTY ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] RaulGracia commented on a change in pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
RaulGracia commented on a change in pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#discussion_r736690901
##########
File path: bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt
##########
@@ -232,8 +232,6 @@ Apache Software License, Version 2.
- lib/io.netty-netty-transport-native-unix-common-4.1.68.Final.jar [11]
- lib/org.apache.logging.log4j-log4j-1.2-api-2.14.1.jar [16]
- lib/org.apache.logging.log4j-log4j-api-2.14.1.jar [16]
-- lib/org.apache.logging.log4j-log4j-core-2.14.1.jar [16]
Review comment:
Thanks @eolivelli, yes in fact this is a package benefiting from the previous transitive import of the log binding related to `bookkeeper-server`. Once removed from `bookkeeper-server`, I was not getting the bindings in the distribution. I have specifically added these bindings in the `build.gradle` (the bindings were already defined in the `pom.xml`). Now there are no changes in this License file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2838: Issue 2837: Remove unnecessary log4j bindings from Bookkeeper packages
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2838:
URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-948590677
@RaulGracia Any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org