[GitHub] hughhhh commented on a change in pull request #5020: Make port number optional in superset for druid

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #5020: Make port number optional in superset for druid
URL: https://github.com/apache/incubator-superset/pull/5020#discussion_r188767360
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -116,7 +116,12 @@ def data(self):
     def get_base_url(host, port):
         if not re.match('http(s)?://', host):
             host = 'http://' + host
-        return '{0}:{1}'.format(host, port)
+
+        if port:
 
 Review comment:
   nit: 
   ```
   url = '{0}:{1}'.format(host, port) if port else host
   return url
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org