[GitHub] [skywalking] wu-sheng commented on a change in pull request #8544: Add component id for Python FastAPI plugin

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #8544:
URL: https://github.com/apache/skywalking/pull/8544#discussion_r805546877



##########
File path: CHANGES.md
##########
@@ -57,6 +57,8 @@ Release Notes.
 * Expose configuration `responseTimeout` of ES client.
 * Support datasource metric analysis.
 * [Break Change] Keep the endpoint avg resp time meter name the same with others scope. (This may break 3rd party integration and existing alarm rule settings)
+* Add Python FastApi component ID(7014) with mapping information.
+* Add env variables `SW_FASTAPI_COLLECT_HTTP_PARAMS` for the plugin of FastApi.

Review comment:
       This is not a relative change log.

##########
File path: CHANGES.md
##########
@@ -57,6 +57,8 @@ Release Notes.
 * Expose configuration `responseTimeout` of ES client.
 * Support datasource metric analysis.
 * [Break Change] Keep the endpoint avg resp time meter name the same with others scope. (This may break 3rd party integration and existing alarm rule settings)
+* Add Python FastApi component ID(7014) with mapping information.

Review comment:
       This is a wrong change log. You don't add mapping information.
   ```suggestion
   * Add Python FastApi component ID(7014).
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org