[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2500: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1312851631


##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -410,21 +394,18 @@ private void startIndexes() {
         int catalogVersion = catalogManager.latestCatalogVersion();
         long causalityToken = recoveryFinishedFuture.join();
 
-        NamedListView<TableView> tableListView = tablesCfg.tables().value();
-
         List<CompletableFuture<?>> startIndexFutures = new ArrayList<>();
 
         for (CatalogIndexDescriptor index : catalogManager.indexes(catalogVersion)) {
-            CatalogTableDescriptor table = catalogManager.table(index.tableId(), catalogVersion);
+            int tableId = index.tableId();
 
-            assert table != null : "tableId=" + index.tableId() + ", indexId=" + index.id();
+            CatalogTableDescriptor table = catalogManager.table(tableId, catalogVersion);
 
-            // TODO: IGNITE-19499 Only catalog should be used
-            int configTableId = getConfigTableId(table.name(), tableListView);
+            assert table != null : "tableId=" + tableId + ", indexId=" + index.id();
 
-            CompletableFuture<?> fireCreateIndexEventFuture = fireCreateIndexEvent(index, causalityToken, configTableId);
+            CompletableFuture<?> fireCreateIndexEventFuture = fireCreateIndexEvent(index, causalityToken, tableId);

Review Comment:
   1. Do we need IndexEvents? Seems, no one use them.
   2. If yes, then will it be correctly to register index in table, then fire the event?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org