You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/07 08:06:28 UTC

[GitHub] [beam] JozoVilcek commented on pull request #15051: [BEAM-12493] Add custom sharding function to FileIO

JozoVilcek commented on pull request #15051:
URL: https://github.com/apache/beam/pull/15051#issuecomment-875385541


   @aaltay I agree about tests. I was looking for existing ones to update but did not succeed. I am happy to add tests if this can get conceptually approved. Right now it is being discussed if sharding function should be exposed at API level:
   https://lists.apache.org/thread.html/r5e91d1996479defbf5e896dca3cf237ee2d9b59396cb3c4edf619df1%40%3Cdev.beam.apache.org%3E
   
   You can chime in if you have some thoughts on this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org