You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/09/03 07:18:25 UTC
[GitHub] [fineract] vidakovic opened a new pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
vidakovic opened a new pull request #1314:
URL: https://github.com/apache/fineract/pull/1314
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [x] Integration tests have been created/updated for verifying the changes made.
- [x] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable merged pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
edcable merged pull request #1314:
URL: https://github.com/apache/fineract/pull/1314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1314:
URL: https://github.com/apache/fineract/pull/1314#issuecomment-687150803
> @francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.
@vidakovic , i have looked at the changes made and they are ok to me.
and i do agree to to the merge as i recall there were users of 1.4 that complained about the SQL Group By error.
This PR addresses the sql error and caters for 1.4 users who use mySQL 5.7 that demands full GROUP BY SQL statements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1314:
URL: https://github.com/apache/fineract/pull/1314#issuecomment-686305803
@francisguchie please have a look at this when you have a moment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie edited a comment on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
francisguchie edited a comment on pull request #1314:
URL: https://github.com/apache/fineract/pull/1314#issuecomment-687150803
> @francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.
@vidakovic , i have looked at the changes made and they are ok to me.
and i do agree to to the merge as i recall there were users of 1.4 that complained about the SQL Group By error. (https://github.com/apache/fineract/pull/1166)
This PR addresses the sql error and caters for 1.4 users who use mySQL 5.7 that demands full GROUP BY SQL statements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1314:
URL: https://github.com/apache/fineract/pull/1314#issuecomment-687132467
@francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1314:
URL: https://github.com/apache/fineract/pull/1314#issuecomment-687156084
@francisguchie thanks a ton for taking the time... @ptuomola @vorburger can one of you take over the merge please as per new rules for PR merges? Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org