You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/16 09:35:03 UTC
Review Request 55562: Added Capability field to SlaveInfo protobuf
message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55562/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Bugs: MESOS-6854
https://issues.apache.org/jira/browse/MESOS-6854
Repository: mesos
Description
-------
Frameworks can advertise their capabilities via the protobuf field
in FrameworkInfo and master can behave differently according them.
Similarly, agents should be able to advertise their capabilities in
a mixed cluster, so that master could make better decisions based
on them. For example, multi-role frameworks could only launch tasks
on agents with multi-role capabilities.
Diffs
-----
include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
Diff: https://reviews.apache.org/r/55562/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 55562: Added Capability field to SlaveInfo protobuf
message.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55562/#review161949
-----------------------------------------------------------
Ship it!
Looks good. We should add a TODO to consider exposing this to schedulers and executors.
- Benjamin Mahler
On Jan. 16, 2017, 9:35 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55562/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 9:35 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-6902
> https://issues.apache.org/jira/browse/MESOS-6902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Frameworks can advertise their capabilities via the protobuf field
> in FrameworkInfo and master can behave differently according them.
> Similarly, agents should be able to advertise their capabilities in
> a mixed cluster, so that master could make better decisions based
> on them. For example, multi-role frameworks could only launch tasks
> on agents with multi-role capabilities.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
> include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
>
> Diff: https://reviews.apache.org/r/55562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 55562: Added Capability field to SlaveInfo protobuf
message.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55562/
-----------------------------------------------------------
(Updated Jan. 16, 2017, 5:35 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Bugs: MESOS-6902
https://issues.apache.org/jira/browse/MESOS-6902
Repository: mesos
Description
-------
Frameworks can advertise their capabilities via the protobuf field
in FrameworkInfo and master can behave differently according them.
Similarly, agents should be able to advertise their capabilities in
a mixed cluster, so that master could make better decisions based
on them. For example, multi-role frameworks could only launch tasks
on agents with multi-role capabilities.
Diffs
-----
include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
Diff: https://reviews.apache.org/r/55562/diff/
Testing
-------
Thanks,
Jay Guo