You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/03 15:05:14 UTC

[GitHub] [apisix] membphis commented on a change in pull request #2953: fix: change string concat

membphis commented on a change in pull request #2953:
URL: https://github.com/apache/apisix/pull/2953#discussion_r535310978



##########
File path: apisix/plugins/sls-logger.lua
##########
@@ -126,26 +127,23 @@ local function remove_stale_objects(premature)
 end
 
 local function combine_syslog(entries)
-    local data
+    local data = {}

Review comment:
       how about the name `items`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org