You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zouboan (via GitHub)" <gi...@apache.org> on 2024/02/02 07:48:04 UTC
[PR] boards/stm32_bbsram.c: fix some build error when enable BBSRAM [nuttx]
zouboan opened a new pull request, #11642:
URL: https://github.com/apache/nuttx/pull/11642
## Summary
When CONFIG_STM32_BBSRAM or ONFIG_STM32F7_BBSRAM enabled, a build error will be reported:
```
CC: board/stm32_bbsram.c board/stm32_bbsram.c:139:3: error: conflicting types for 'stack_t'
139 | } stack_t;
| ^~~~~~~
```
Because typedef of stack_t conflicting with typedef of stack_t in include/signal.h
## Impact
BBSRAM in nucleo-f429zi and nucleo-144
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/stm32_bbsram.c: fix some build error when enable BBSRAM [nuttx]
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on code in PR #11642:
URL: https://github.com/apache/nuttx/pull/11642#discussion_r1475772813
##########
boards/arm/stm32/nucleo-f429zi/src/stm32_bbsram.c:
##########
@@ -237,7 +237,7 @@ typedef struct
int lineno; /* __LINE__ to up_assert */
pid_t pid; /* Process ID */
uint32_t regs[XCPTCONTEXT_REGS]; /* Interrupt register save area */
- stack_t stacks; /* Stack info */
+ stacks_t stacks; /* Stack info */
Review Comment:
Please fix the indent here
##########
boards/arm/stm32f7/nucleo-144/src/stm32_bbsram.c:
##########
@@ -237,7 +237,7 @@ typedef struct
int lineno; /* __LINE__ to up_assert */
int pid; /* Process ID */
uint32_t regs[XCPTCONTEXT_REGS]; /* Interrupt register save area */
- stack_t stacks; /* Stack info */
+ stacks_t stacks; /* Stack info */
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/stm32_bbsram.c: fix some build error when enable BBSRAM [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #11642:
URL: https://github.com/apache/nuttx/pull/11642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/stm32_bbsram.c: fix some build error when enable BBSRAM [nuttx]
Posted by "zouboan (via GitHub)" <gi...@apache.org>.
zouboan commented on code in PR #11642:
URL: https://github.com/apache/nuttx/pull/11642#discussion_r1475794644
##########
boards/arm/stm32/nucleo-f429zi/src/stm32_bbsram.c:
##########
@@ -237,7 +237,7 @@ typedef struct
int lineno; /* __LINE__ to up_assert */
pid_t pid; /* Process ID */
uint32_t regs[XCPTCONTEXT_REGS]; /* Interrupt register save area */
- stack_t stacks; /* Stack info */
+ stacks_t stacks; /* Stack info */
Review Comment:
done
##########
boards/arm/stm32f7/nucleo-144/src/stm32_bbsram.c:
##########
@@ -237,7 +237,7 @@ typedef struct
int lineno; /* __LINE__ to up_assert */
int pid; /* Process ID */
uint32_t regs[XCPTCONTEXT_REGS]; /* Interrupt register save area */
- stack_t stacks; /* Stack info */
+ stacks_t stacks; /* Stack info */
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org