You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/14 06:56:56 UTC
[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
zhangjidi2016 opened a new pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69
## What is the purpose of the change
#68
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785308006
##########
File path: src/main/resources/application.yml
##########
@@ -41,8 +41,9 @@ rocketmq:
# if this value is empty,use env value rocketmq.config.namesrvAddr NAMESRV_ADDR | now, default localhost:9876
# configure multiple namesrv addresses to manage multiple different clusters
namesrvAddrs:
- - 127.0.0.1:9876
- - 127.0.0.2:9876
+# - 10.253.141.99:9876;10.253.141.102:9876
+ - 100.76.6.97:9876
Review comment:
Forgot to change back when testing locally
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
Review comment:
done
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ if (groupList != null && !groupList.getGroupList().isEmpty()) {
+ for (String group : groupList.getGroupList()) {
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ String statsKey = String.format("%s@%s", topic, group);
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.GROUP_GET_NUMS, statsKey);
+ outTPS += bsd.getStatsMinute().getTps();
+ outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ }
+ }
+
+ List<String> list;
+ try {
+ list = dashboardCollectService.getTopicMap().get(topic);
+ } catch (ExecutionException e) {
+ throw Throwables.propagate(e);
+ }
+ if (null == list) {
+ list = Lists.newArrayList();
+ }
+
+ list.add(date.getTime() + "," + new BigDecimal(inTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + inMsgCntToday + "," + new BigDecimal(outTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + outMsgCntToday);
+ dashboardCollectService.getTopicMap().put(topic, list);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r784650572
##########
File path: src/main/resources/application.yml
##########
@@ -41,8 +41,9 @@ rocketmq:
# if this value is empty,use env value rocketmq.config.namesrvAddr NAMESRV_ADDR | now, default localhost:9876
# configure multiple namesrv addresses to manage multiple different clusters
namesrvAddrs:
- - 127.0.0.1:9876
- - 127.0.0.2:9876
+# - 10.253.141.99:9876;10.253.141.102:9876
+ - 100.76.6.97:9876
Review comment:
Suggest using localhost but not specific host
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
Review comment:
Suggest to print the exception stack
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.dashboard.task;
+
+import com.google.common.base.Throwables;
+import com.google.common.collect.Lists;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.BrokerStatsData;
+import org.apache.rocketmq.common.protocol.body.GroupList;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.common.protocol.route.TopicRouteData;
+import org.apache.rocketmq.dashboard.service.DashboardCollectService;
+import org.apache.rocketmq.store.stats.BrokerStatsManager;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.apache.rocketmq.tools.command.stats.StatsAllSubCommand;
+
+@Slf4j
+public class CollectTaskRunnble implements Runnable {
+
+ private String topic;
+
+ private MQAdminExt mqAdminExt;
+
+ private DashboardCollectService dashboardCollectService;
+
+ public CollectTaskRunnble(String topic, MQAdminExt mqAdminExt,
+ DashboardCollectService dashboardCollectService) {
+ this.topic = topic;
+ this.mqAdminExt = mqAdminExt;
+ this.dashboardCollectService = dashboardCollectService;
+ }
+
+ @Override
+ public void run() {
+ Date date = new Date();
+ try {
+ TopicRouteData topicRouteData = mqAdminExt.examineTopicRouteInfo(topic);
+ GroupList groupList = mqAdminExt.queryTopicConsumeByWho(topic);
+ double inTPS = 0;
+ long inMsgCntToday = 0;
+ double outTPS = 0;
+ long outMsgCntToday = 0;
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.TOPIC_PUT_NUMS, topic);
+ inTPS += bsd.getStatsMinute().getTps();
+ inMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data TOPIC_PUT_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ if (groupList != null && !groupList.getGroupList().isEmpty()) {
+ for (String group : groupList.getGroupList()) {
+ for (BrokerData bd : topicRouteData.getBrokerDatas()) {
+ String masterAddr = bd.getBrokerAddrs().get(MixAll.MASTER_ID);
+ if (masterAddr != null) {
+ try {
+ String statsKey = String.format("%s@%s", topic, group);
+ BrokerStatsData bsd = mqAdminExt.viewBrokerStatsData(masterAddr, BrokerStatsManager.GROUP_GET_NUMS, statsKey);
+ outTPS += bsd.getStatsMinute().getTps();
+ outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
+ } catch (Exception e) {
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
+ log.warn("Response [{}] ", e.getMessage());
+ }
+ }
+ }
+ }
+ }
+
+ List<String> list;
+ try {
+ list = dashboardCollectService.getTopicMap().get(topic);
+ } catch (ExecutionException e) {
+ throw Throwables.propagate(e);
+ }
+ if (null == list) {
+ list = Lists.newArrayList();
+ }
+
+ list.add(date.getTime() + "," + new BigDecimal(inTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + inMsgCntToday + "," + new BigDecimal(outTPS).setScale(5, BigDecimal.ROUND_HALF_UP) + "," + outMsgCntToday);
+ dashboardCollectService.getTopicMap().put(topic, list);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
Suggest avoid using `e.printStackTrace()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785317576
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -83,8 +82,7 @@ public void run() {
outTPS += bsd.getStatsMinute().getTps();
outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
- log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
- log.warn("Response [{}] ", e.getMessage());
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed", e.getMessage());
Review comment:
[Trivial] Usually log exception stack instead of not only exception message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785317576
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -83,8 +82,7 @@ public void run() {
outTPS += bsd.getStatsMinute().getTps();
outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
- log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
- log.warn("Response [{}] ", e.getMessage());
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed", e.getMessage());
Review comment:
[Trivial] Log exception stack instead of exception message is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69#discussion_r785317576
##########
File path: src/main/java/org/apache/rocketmq/dashboard/task/CollectTaskRunnble.java
##########
@@ -83,8 +82,7 @@ public void run() {
outTPS += bsd.getStatsMinute().getTps();
outMsgCntToday += StatsAllSubCommand.compute24HourSum(bsd);
} catch (Exception e) {
- log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed");
- log.warn("Response [{}] ", e.getMessage());
+ log.warn("Exception caught: mqAdminExt get broker stats data GROUP_GET_NUMS failed", e.getMessage());
Review comment:
[Trivial] Usually log exception stack instead of exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] zhangjidi2016 merged pull request #69: [ISSUE #68]Use multithreading for topic data collection in collectTask
Posted by GitBox <gi...@apache.org>.
zhangjidi2016 merged pull request #69:
URL: https://github.com/apache/rocketmq-dashboard/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org