You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Zhengxi Li (Jira)" <ji...@apache.org> on 2020/11/29 23:39:00 UTC

[jira] [Updated] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter

     [ https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhengxi Li updated MAPREDUCE-7311:
----------------------------------
    Description: 
The test {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.
h3. Details

Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when`testBytesWrittenRespectingLimit` writes some bytes on the local file system, some counters are being incremented. The problem is that, after the test is done, the counter is not reset. With this polluted shared state, assumptions are broken, resulting in test failure in the second run.

  was:
The test {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.
h3. Details

Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when\{{`testBytesWrittenRespectingLimit`}} writes some bytes on the local file system, some counters are being incremented. The problem is that, after the test is done, the counter is not reset. With this polluted shared state, assumptions are broken, resulting in test failure in the second run.


> Fix non-idempotent test in TestTaskProgressReporter
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-7311
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Zhengxi Li
>            Priority: Minor
>
> The test {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes some bytes on the local file system, some counters are being incremented. The problem is that, after the test is done, the counter is not reset. With this polluted shared state, assumptions are broken, resulting in test failure in the second run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org