You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "melloware (via GitHub)" <gi...@apache.org> on 2023/07/27 16:52:06 UTC

[GitHub] [myfaces] melloware opened a new pull request, #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

melloware opened a new pull request, #605:
URL: https://github.com/apache/myfaces/pull/605

   MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size
   
   @tandraschko I think this is all MyFaces needed to do i didn't make any taglib changes because I can't seem to figure out how to add the docs for the taglib.xml?  It looks like its generated somehow but I don't quite see the magic?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1654057723

   Also these tests are failing and want to make sure they are correctly failing before I fix them?
   
   ```
   Error:  Errors: 
   Error:    UIRepeatTest.testSaveAndRestorePortletLifecycleWithoutPss1:119 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    AcidARCacheELMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    AcidNoPssMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    AcidPssRefreshMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    AcidPssRefreshPreserveStateMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testInvokeOnComponent:133 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testInvokeOnComponentBeginEnd:822 » LocationAwareFaces when 'value' attribute is not set, you need 'begin' attribute instead of 'offset' attribute
   Error:    RepeatTestCase.testInvokeOnEmptyList:879 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testInvokeOnNullModel:853 » LocationAwareFaces when 'value' attribute is not set, you need 'begin' attribute instead of 'offset' attribute
   Error:    RepeatTestCase.testRepeat:70 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset:364 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset2:783 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset_0:398 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset_0_7:457 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset_1:587 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testRepeatOffset_1_7:653 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   Error:    RepeatTestCase.testVisitTree:267 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1660307777

   OK all tests updated and passing.   I still don't understand how I can update the taglib.xml to add the text descriptions for these attributes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1664742278

   I will try the Java doc and see if it generates the TLD correctly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1660583634

   Yeah this get generated on every build:
   
   ![image](https://github.com/apache/myfaces/assets/4399574/636975c5-1f1d-4208-8aaf-c9d8822788be)
   
   And I can see the docs are empty?
   
   ```xml
    <!-- Component Tags -->
      <tag>
         <description><![CDATA[]]></description>
         <name>repeat</name>
         <tag-class>$component.tagClass</tag-class>
         <body-content>JSP</body-content>
         
         <attribute>
            <description><![CDATA[]]></description>
            <name>offset</name>
            <deferred-value>
                <type>int</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>size</name>
            <deferred-value>
                <type>int</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>step</name>
            <deferred-value>
                <type>int</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>begin</name>
            <deferred-value>
                <type>int</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>end</name>
            <deferred-value>
                <type>int</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>var</name>
            <rtexprvalue>false</rtexprvalue>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>varStatus</name>
            <rtexprvalue>false</rtexprvalue>
         </attribute>
         <attribute>
            <description><![CDATA[]]></description>
            <name>value</name>
            <deferred-value>
                <type>java.lang.Object</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[Get a string which uniquely identifies this UIComponent within the scope of the nearest ancestor NamingContainer
   component. The id is not necessarily unique across all components in the current view.]]></description>
            <name>id</name>
            <rtexprvalue>true</rtexprvalue>
         </attribute>
         <attribute>
            <description><![CDATA[A boolean value that indicates whether this component should be rendered. Default value: true.]]></description>
            <name>rendered</name>
            <deferred-value>
                <type>boolean</type>
            </deferred-value>
         </attribute>
         <attribute>
            <description><![CDATA[Identifies a backing bean property (of type UIComponent or appropriate subclass) to bind " + "to this component instance. This value must be an EL expression.]]></description>
            <name>binding</name>
            <deferred-value>
                <type>jakarta.faces.component.UIComponent</type>
            </deferred-value>
         </attribute>
      </tag>
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1658340405

   I will look at the tests.  It was just an awful lot of failures that I was not expecting but let me investigate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] tandraschko commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1660550478

   do we even have a taglib?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Faces 5.0: MYFACES-4618: ui:repeat clarification on attributes, such as offset and size [myfaces]

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #605:
URL: https://github.com/apache/myfaces/pull/605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1659210317

   OK I have it down to 1 failing test I am trying to figure out why it is failing.  I had to remove some tests that were completely invalid based on these new rules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] tandraschko commented on pull request #605: MYFACES-4618: 4.1: ui:repeat clarification on attributes, such as offset and size

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #605:
URL: https://github.com/apache/myfaces/pull/605#issuecomment-1657951405

   can you please check if those are really invalid tests now?
   
   maybe we have to think about a config, to disable those checks for easier migration; not sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org