You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/13 06:27:41 UTC

[GitHub] feng-tao commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context

feng-tao commented on a change in pull request #2256: [AIRFLOW-1153] Fix issue ' params ' don't pass to HiveOperator execution context
URL: https://github.com/apache/airflow/pull/2256#discussion_r247335514
 
 

 ##########
 File path: airflow/utils/operator_helpers.py
 ##########
 @@ -43,7 +43,8 @@ def context_to_airflow_vars(context, in_env_var_format=False):
     :type in_env_var_format: bool
     :return task_instance context as dict.
     """
-    params = dict()
+    params = context.get('params')
 
 Review comment:
   this won't work if the context doesn't specify params wihch params will be assigned None. You could do something like
   params = context.get('params', dict())

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services