You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/01/07 00:42:20 UTC
[GitHub] [datasketches-java] leerho opened a new pull request #380: In executing Clover in prep for release I found some obsolete classes in
leerho opened a new pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380
AoD that were totally not used (probably my bad!).
I also found some critical missing functionality at the root Sketch
level. So I added that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] AlexanderSaydakov commented on a change in pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on a change in pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380#discussion_r780483711
##########
File path: src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
##########
@@ -63,7 +63,8 @@
HeapArrayOfDoublesQuickSelectSketch(final int nomEntries, final int lgResizeFactor,
final float samplingProbability, final int numValues, final long seed) {
super(numValues, seed);
- nomEntries_ = nomEntries;
+ lgNomEntries_ =
+ org.apache.datasketches.Util.simpleLog2OfLong(org.apache.datasketches.Util.ceilingPowerOf2(nomEntries));
Review comment:
perhaps this fully qualified name is avoidable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on a change in pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
leerho commented on a change in pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380#discussion_r780592354
##########
File path: src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
##########
@@ -63,7 +63,8 @@
HeapArrayOfDoublesQuickSelectSketch(final int nomEntries, final int lgResizeFactor,
final float samplingProbability, final int numValues, final long seed) {
super(numValues, seed);
- nomEntries_ = nomEntries;
+ lgNomEntries_ =
+ org.apache.datasketches.Util.simpleLog2OfLong(org.apache.datasketches.Util.ceilingPowerOf2(nomEntries));
Review comment:
I will fix using import static ...method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on a change in pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
leerho commented on a change in pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380#discussion_r780592354
##########
File path: src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
##########
@@ -63,7 +63,8 @@
HeapArrayOfDoublesQuickSelectSketch(final int nomEntries, final int lgResizeFactor,
final float samplingProbability, final int numValues, final long seed) {
super(numValues, seed);
- nomEntries_ = nomEntries;
+ lgNomEntries_ =
+ org.apache.datasketches.Util.simpleLog2OfLong(org.apache.datasketches.Util.ceilingPowerOf2(nomEntries));
Review comment:
I will fix using import static ...method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
leerho merged pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] AlexanderSaydakov commented on a change in pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on a change in pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380#discussion_r780483711
##########
File path: src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
##########
@@ -63,7 +63,8 @@
HeapArrayOfDoublesQuickSelectSketch(final int nomEntries, final int lgResizeFactor,
final float samplingProbability, final int numValues, final long seed) {
super(numValues, seed);
- nomEntries_ = nomEntries;
+ lgNomEntries_ =
+ org.apache.datasketches.Util.simpleLog2OfLong(org.apache.datasketches.Util.ceilingPowerOf2(nomEntries));
Review comment:
perhaps this fully qualified name is avoidable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #380: In executing Clover in prep for release I found some obsolete classes in
Posted by GitBox <gi...@apache.org>.
leerho merged pull request #380:
URL: https://github.com/apache/datasketches-java/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org