[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #8874: [refactor] some code cleanup for min/max function.

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#discussion_r851593774


##########
be/src/exprs/aggregate_functions.cpp:
##########
@@ -654,22 +654,6 @@ void AggregateFunctions::min(FunctionContext*, const DecimalV2Val& src, DecimalV
     }
 }
 
-template <>
-void AggregateFunctions::min(FunctionContext*, const LargeIntVal& src, LargeIntVal* dst) {
-    if (src.is_null) {

Review Comment:
   why delete this function? LargeIntValue is not used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org