You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/11/30 14:42:22 UTC
[GitHub] [ozone] elek opened a new pull request #1637: HDDS-4526. Remove false-positive error logs from LeaseManager
elek opened a new pull request #1637:
URL: https://github.com/apache/ozone/pull/1637
## What changes were proposed in this pull request?
There is an error log which can be seen frequently in the log:
```
2020-11-30 15:35:58,539 [CommandWatcher-LeaseManager#LeaseMonitor] ERROR lease.LeaseManager (LeaseManager.java:run(238)) - Execution was interrupted
java.lang.InterruptedException: sleep interrupted
at java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.ozone.lease.LeaseManager$LeaseMonitor.run(LeaseManager.java:234)
at java.lang.Thread.run(Thread.java:748)
```
This log is introduced by HDDS-2561 to make Sonar happy, but it was not required as LeaseManager use the thread interrupt intentionally.
For a proper fix we can keep the logging on WARN level AND replace thread interrupts with thread notify/wait.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4526
## How was this patch tested?
Unit test. `TestLeaseManager` has good coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #1637: HDDS-4526. Remove false-positive error logs from LeaseManager
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1637:
URL: https://github.com/apache/ozone/pull/1637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1637: HDDS-4526. Remove false-positive error logs from LeaseManager
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1637:
URL: https://github.com/apache/ozone/pull/1637#issuecomment-743185456
Thanks @elek for fixing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org