[GitHub] rabbah commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

[gi...@git.apache.org]

rabbah commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety
URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r140899259
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
 ##########
 @@ -202,7 +206,11 @@ class MessageFeed(description: String,
   private def sendOutstandingMessages(): Unit = {
     val occupancy = outstandingMessages.size
     if (occupancy > 0 && handlerCapacity > 0) {
-      val (topic, partition, offset, bytes) = outstandingMessages.dequeue()
+      // Easiest way with an immutable queue to cleanly dequeue
+      // Head is the first elemeent of the queue, desugared w/ a assignment pattern
 
 Review comment:
   a assignment -> an assignment
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services