You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "malinjawi (via GitHub)" <gi...@apache.org> on 2026/08/23 11:13:41 UTC

[PR] [MINOR][VL] Delta: Drop stray Meta license header from native Delta files [gluten]

malinjawi opened a new pull request, #12868:
URL: https://github.com/apache/gluten/pull/12868

   ## What changes are proposed in this pull request?
   
   Fifteen files under `cpp/velox/compute/delta/` carry two stacked license blocks: the ASF header, followed by a second full Apache-2.0 block headed `Copyright (c) Facebook, Inc. and its affiliates.`
   
   This was raised by @philo-he on #12040. The native Delta code was originally written on a Velox fork branch under `velox/connectors/hive/delta/`, where Velox's file template carries that header. When the code was ported into Gluten the ASF header was prepended on top of it rather than replacing it, so both blocks survived. The code was never merged into the Velox project, so the Meta copyright does not apply to it.
   
   This PR removes the stray block and leaves the ASF header alone. The affected files came from #12040 (13 files) and #12001 (`RoaringBitmapArray.{h,cpp}`); the Delta files added later — `DeltaSplitInfo.h`, `tests/DeltaBitmapAggregatorTest.cpp`, `tests/RoaringBitmapArrayTest.cpp` — already carry the ASF header only, so this makes the directory consistent.
   
   Comment-only change: 225 deletions, 0 insertions, no code touched.
   
   ## How was this patch tested?
   
   No functional change, so no new tests.
   
   - verified the diff removes comment lines only (`git diff -U0`, 15 files, 225 deletions / 0 insertions)
   - `python3 .github/workflows/util/license-header.py -vk -` reports `OK` for all 15 files
   - clang-format clean over the changed files
   - existing native Delta unit tests are unaffected and continue to build
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: IBM BOB
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR][VL] Delta: Drop stray Meta license header from native Delta files [gluten]

Posted by "philo-he (via GitHub)" <gi...@apache.org>.
philo-he merged PR #12868:
URL: https://github.com/apache/gluten/pull/12868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org