You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Emil Anca <ea...@hortonworks.com> on 2015/05/05 15:47:29 UTC
Re: Review Request 33521: Internal Exception:
org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
not exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/
-----------------------------------------------------------
(Updated May 5, 2015, 1:47 p.m.)
Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
Changes
-------
Addressed reviewer comments.
Bugs: AMBARI-10665
https://issues.apache.org/jira/browse/AMBARI-10665
Repository: ambari
Description
-------
PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
SOLUTION: Added missing columns
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 879cf31
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d32f3cd
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f98fb05
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7
Diff: https://reviews.apache.org/r/33521/diff/
Testing
-------
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [6.912s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
[INFO] Ambari Web ........................................ SUCCESS [29.655s]
[INFO] Ambari Views ...................................... SUCCESS [1.196s]
[INFO] Ambari Admin View ................................. SUCCESS [19.873s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
[INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
[INFO] Ambari Agent ...................................... SUCCESS [9.179s]
[INFO] Ambari Client ..................................... SUCCESS [0.202s]
[INFO] Ambari Python Client .............................. SUCCESS [1.121s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
[INFO] Ambari Shell ...................................... SUCCESS [0.108s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Emil Anca
Re: Review Request 33521: Internal Exception:
org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
not exist
Posted by Costel Radulescu <cr...@hortonworks.com>.
> On May 5, 2015, 5:17 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 491
> > <https://reviews.apache.org/r/33521/diff/4/?file=950135#file950135line491>
> >
> > Actually, will config_attributes contain more than 4k characters? If yes, then we need to switch back to TEXT, LONGTEXT, CLOB.
After a deeper analysis I concluded that the config_attributes column can exceed 4k characters. The code has been updated to reflect the findings as follows:
- posgresql - TEXT
- mysql - LONGTEXT
- oracle - CLOB
- sqlserver - VARCHAR(MAX)
- Costel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/#review82530
-----------------------------------------------------------
On May 5, 2015, 1:47 p.m., Emil Anca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33521/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 1:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-10665
> https://issues.apache.org/jira/browse/AMBARI-10665
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
>
> SOLUTION: Added missing columns
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 879cf31
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d32f3cd
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f98fb05
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7
>
> Diff: https://reviews.apache.org/r/33521/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.912s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
> [INFO] Ambari Web ........................................ SUCCESS [29.655s]
> [INFO] Ambari Views ...................................... SUCCESS [1.196s]
> [INFO] Ambari Admin View ................................. SUCCESS [19.873s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
> [INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
> [INFO] Ambari Agent ...................................... SUCCESS [9.179s]
> [INFO] Ambari Client ..................................... SUCCESS [0.202s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.121s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.108s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Emil Anca
>
>
Re: Review Request 33521: Internal Exception:
org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
not exist
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/#review82530
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
<https://reviews.apache.org/r/33521/#comment133269>
Actually, will config_attributes contain more than 4k characters? If yes, then we need to switch back to TEXT, LONGTEXT, CLOB.
- Alejandro Fernandez
On May 5, 2015, 1:47 p.m., Emil Anca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33521/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 1:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-10665
> https://issues.apache.org/jira/browse/AMBARI-10665
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
>
> SOLUTION: Added missing columns
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 879cf31
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d32f3cd
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f98fb05
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7
>
> Diff: https://reviews.apache.org/r/33521/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.912s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
> [INFO] Ambari Web ........................................ SUCCESS [29.655s]
> [INFO] Ambari Views ...................................... SUCCESS [1.196s]
> [INFO] Ambari Admin View ................................. SUCCESS [19.873s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
> [INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
> [INFO] Ambari Agent ...................................... SUCCESS [9.179s]
> [INFO] Ambari Client ..................................... SUCCESS [0.202s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.121s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.108s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Emil Anca
>
>
Re: Review Request 33521: Internal Exception:
org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
not exist
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/#review82828
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 7, 2015, 2:59 p.m., Emil Anca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33521/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 2:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-10665
> https://issues.apache.org/jira/browse/AMBARI-10665
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
>
> SOLUTION: Added missing columns
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java b27f7ef
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 67f804c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java 49870fe
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 879cf31
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3a3c52b
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9fb0909
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ead0527
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f98fb05
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7
>
> Diff: https://reviews.apache.org/r/33521/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [6.912s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
> [INFO] Ambari Web ........................................ SUCCESS [29.655s]
> [INFO] Ambari Views ...................................... SUCCESS [1.196s]
> [INFO] Ambari Admin View ................................. SUCCESS [19.873s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
> [INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
> [INFO] Ambari Agent ...................................... SUCCESS [9.179s]
> [INFO] Ambari Client ..................................... SUCCESS [0.202s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.121s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.108s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Emil Anca
>
>
Re: Review Request 33521: Internal Exception:
org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
not exist
Posted by Emil Anca <ea...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/
-----------------------------------------------------------
(Updated May 7, 2015, 2:59 p.m.)
Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
Bugs: AMBARI-10665
https://issues.apache.org/jira/browse/AMBARI-10665
Repository: ambari
Description
-------
PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
SOLUTION: Added missing columns
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java b27f7ef
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 67f804c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java 49870fe
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 879cf31
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3a3c52b
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9fb0909
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ead0527
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f98fb05
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7
Diff: https://reviews.apache.org/r/33521/diff/
Testing
-------
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [6.912s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
[INFO] Ambari Web ........................................ SUCCESS [29.655s]
[INFO] Ambari Views ...................................... SUCCESS [1.196s]
[INFO] Ambari Admin View ................................. SUCCESS [19.873s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
[INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
[INFO] Ambari Agent ...................................... SUCCESS [9.179s]
[INFO] Ambari Client ..................................... SUCCESS [0.202s]
[INFO] Ambari Python Client .............................. SUCCESS [1.121s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
[INFO] Ambari Shell ...................................... SUCCESS [0.108s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Emil Anca