[jira] Commented: (WSRP4J-48) WSRP4J never deregisters consumers from consumer

["Mikhail Melamud (JIRA)" <ws...@ws.apache.org>]

     [ http://nagoya.apache.org/jira/browse/WSRP4J-48?page=comments#action_55868 ]
     
Mikhail Melamud commented on WSRP4J-48:
---------------------------------------

I guess, you made a typo: it should be 

consumerRegistry.deregister(request.getRegistrationHandle());

request is already of type RegistrationContext 


> WSRP4J never deregisters consumers from consumer
> ------------------------------------------------
>
>          Key: WSRP4J-48
>          URL: http://nagoya.apache.org/jira/browse/WSRP4J-48
>      Project: WSRP4J
>         Type: Bug
>   Components: Producer
>     Versions: current (nightly)
>     Reporter: Diego Louzán

>
> From org.apache.wsrp4j.producer.driver.WSRPEngine (line 340):
> public ReturnAny deregister(RegistrationContext request) throws java.rmi.RemoteException
> {
>     String MN = "deregister";
>     if (logger.isLogging(Logger.TRACE_HIGH))
>     {
>         logger.entry(Logger.TRACE_HIGH, MN);
>     }
>     // perform parameter check
>     paramCheck.check(request, Constants.NILLABLE_FALSE);
>     try
>     {
>         checkRegistration(request);
>     } catch (WSRPException e)
>     {
>         WSRPXHelper.handleWSRPException(e);
>     }
>     if (logger.isLogging(Logger.TRACE_HIGH))
>     {
>         logger.exit(Logger.TRACE_HIGH, MN);
>     }
>     return new ReturnAny();
> }
> This method is the implementation of deregister operation from WSRP Registration Port in the producer. The code above never deletes the consumer entry in the ConsumerRegistry. Not tested, but I think it should make a call like:
> consumerRegistry.deregister(request.getRegistrationContext().getRegistrationHandle());

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira