You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/04/16 14:24:09 UTC
[GitHub] [carbondata] akashrn5 opened a new pull request #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
akashrn5 opened a new pull request #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716
### Why is this PR needed?
In table exists API, we catch all exceptions and say table does not exists which is wrong
### What changes were proposed in this PR?
Catch only NoSuchTableException fro spark and return false, for other exceptions, throw it to caller
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-614787949
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
and register NI as a function
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check and register NI as a function
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-614863987
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1046/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-615109406
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-615103744
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2760/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3716: [CARBONDATA-3774]Fix
hiding the actual exceptions during tableExists check
Posted by GitBox <gi...@apache.org>.
jackylk commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-615538084
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3716: [CARBONDATA-3774]Fix
hiding the actual exceptions during tableExists check
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
URL: https://github.com/apache/carbondata/pull/3716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
and register NI as a function
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check and register NI as a function
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-614871782
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2759/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 removed a comment on issue #3716:
[CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check
and register NI as a function
Posted by GitBox <gi...@apache.org>.
akashrn5 removed a comment on issue #3716: [CARBONDATA-3774]Fix hiding the actual exceptions during tableExists check and register NI as a function
URL: https://github.com/apache/carbondata/pull/3716#issuecomment-614787949
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services