[GitHub] larroy commented on issue #12791: [MXNET-1093] Add python3 Docker images for each MXNet release

[GitBox <gi...@apache.org>]

larroy commented on issue #12791: [MXNET-1093] Add python3 Docker images for each MXNet release
URL: https://github.com/apache/incubator-mxnet/pull/12791#issuecomment-435053999
 
 
   Thanks for this effort. I have some reservations about the implementation, see my previous comment about zombie containers and resource disposal in the code.
   
   Also, can we use Python instead of shell to automate these steps? It's more robust, debuggable, flexible and easier to mantain, we don't want to introduce complex logic in shell scripts. 
   
   All the automation on the project is done in Python. The code that is forking process to parallelize the build should be done as it's done in https://github.com/apache/incubator-mxnet/blob/master/ci/docker_cache.py or with a similar Python construct of your choice. Even if it's not critical to parallelize building of the images, if the code is well factored and building the container it's on its own function is very easy to parallelize.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services