Re: [PR] feat(alerts): Adding custom Header and StyledPanel components for use in alerts&reports modal redesign [superset]

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #25975:
URL: https://github.com/apache/superset/pull/25975#issuecomment-1811060549

   > @michael-s-molina I've refactored the code such that it is only adding new components to the alerts&reports components where it we be implemented. Changes to the Collapse component have been reverted. @hughhhh In the refactor, I've removed the need for override the ts checks, so all of the `@ts-ignore` lines have been removed.
   
   @fisjac I'm trying to better understand the context for this PR. Are you planning to change the default implementation of Alerts and Reports of Superset or override the default implementation of Superset in your installation? The reason I'm asking is because the components you created are not referenced anywhere.
   
   If you are trying to override the default implementation of Superset in your installation, then these components don't belong to Superset codebase but to your codebase. What the Superset Collapse panel component needs to provide is a property that allow you to override the header component.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org