You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/04/15 01:08:16 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #40797: [SPARK-43042] [SS] [Connect] Add table() API support for DataStreamReader

amaliujia commented on code in PR #40797:
URL: https://github.com/apache/spark/pull/40797#discussion_r1167351179


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -874,6 +874,14 @@ class SparkConnectPlanner(val session: SparkSession) {
             s"Predicates are not supported for ${rel.getDataSource.getFormat} data sources.")
         }
 
+      case proto.Read.ReadTypeCase.NAMED_TABLE if rel.getIsStreaming =>
+        val multipartIdentifier =
+          CatalystSqlParser.parseMultipartIdentifier(rel.getNamedTable.getUnparsedIdentifier)
+        UnresolvedRelation(
+          multipartIdentifier,
+          new CaseInsensitiveStringMap(rel.getNamedTable.getOptionsMap),
+          isStreaming = true)

Review Comment:
   hmm shouldn't this just be `isStreaming = rel.getIsStreaming`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org