[GitHub] [arrow] felipecrv commented on a diff in pull request #35149: GH-35141: [C++] Versions of IsNull/IsValid that don't branch on type

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #35149:
URL: https://github.com/apache/arrow/pull/35149#discussion_r1183945056


##########
cpp/src/arrow/array/array_base.h:
##########
@@ -69,16 +69,37 @@ class ARROW_EXPORT Array {
     // a potential inner-branch removal.
     if (type_id() == Type::SPARSE_UNION) {
       return !internal::IsNullSparseUnion(*data_, i);
-    }

Review Comment:
   More compact. In sync with the `if constexpr` used in the other cases. Arrow's `.clang-tidy` doesn't complain about this. No extra indentation levels are introduced because of this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org