You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by amansinha100 <gi...@git.apache.org> on 2016/08/08 23:52:02 UTC

[GitHub] drill pull request #517: DRILL-4704 fix

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/517#discussion_r73977447
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java ---
    @@ -267,6 +267,17 @@ public LogicalExpression visitBooleanOperator(BooleanOperator op, FunctionLookup
           return new BooleanOperator(op.getName(), args, op.getPosition());
         }
     
    +    static public int computePrecision(LogicalExpression currentArg) {
    +        int precision = currentArg.getMajorType().getPrecision();
    +        if (currentArg.getMajorType().getMinorType() == MinorType.INT) {
    +            precision = 10;
    --- End diff --
    
    These values should preferably be defined as static final constants. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---